From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231])
 by sourceware.org (Postfix) with ESMTPS id 445BA385EC56
 for <libabigail@sourceware.org>; Tue, 26 Jan 2021 16:22:36 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 445BA385EC56
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=dodji@seketeli.org
Received: from localhost (91-166-131-65.subs.proxad.net [91.166.131.65])
 (Authenticated sender: dodji@seketeli.org)
 by relay11.mail.gandi.net (Postfix) with ESMTPSA id 6929510000C;
 Tue, 26 Jan 2021 16:22:33 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 69B36581CAC; Tue, 26 Jan 2021 17:22:32 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: Matthias Maennich <maennich@google.com>,  Giuliano Procida via
 Libabigail <libabigail@sourceware.org>,  kernel-team@android.com
Subject: Re: [PATCH] abipkgdiff: Address operator precedence warning
Organization: Me, myself and I
References: <20210126095655.2964881-1-maennich@google.com>
 <CAGvU0Hms6G4bKZ=TC0hVRdFmEkZtpdD13Y=ZZ-g8JniVgE4ZbA@mail.gmail.com>
X-Operating-System: Fedora 34
X-URL: http://www.seketeli.net/~dodji
Date: Tue, 26 Jan 2021 17:22:32 +0100
In-Reply-To: <CAGvU0Hms6G4bKZ=TC0hVRdFmEkZtpdD13Y=ZZ-g8JniVgE4ZbA@mail.gmail.com>
 (Giuliano Procida's message of "Tue, 26 Jan 2021 11:54:12 +0000")
Message-ID: <87k0rzhdmf.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jan 2021 16:22:42 -0000

Giuliano Procida <gprocida@google.com> a =C3=A9crit:

> On Tue, 26 Jan 2021 at 09:57, Matthias Maennich <maennich@google.com> wro=
te:
>>
>> When compiling with clang, it (rightfully) complains about an operator
>> precedence issue:
>>
>> abipkgdiff.cc:1646:7: error: operator '?:' has lower precedence than '<<=
'; '<<' will be evaluated first [-Wparentheses]
>>       ? string("Comparison against self SUCCEEDED\n")
>>       ^
>>
>> Fix that by properly placing the parentheses. Also, drop the superfluous
>> string conversion.
>>
>>         * tools/abipkgdiff.cc (compare_to_self): address clang warning.
>>
>> Signed-off-by: Matthias Maennich <maennich@google.com>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
>
> Looks good to me.

Applied to master, thanks!

Cheers,

--=20
		Dodji