From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by sourceware.org (Postfix) with ESMTPS id EB32F3851C07 for ; Fri, 2 Oct 2020 21:53:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EB32F3851C07 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 38D941BF206; Fri, 2 Oct 2020 21:53:03 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id DFF8B18008AF; Fri, 2 Oct 2020 09:25:20 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 0/7] Suppression parsing - preparatory work Organization: Me, myself and I References: <20200817093819.172380-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.seketeli.net/~dodji Date: Fri, 02 Oct 2020 09:25:20 +0200 In-Reply-To: <20200817093819.172380-1-gprocida@google.com> (Giuliano Procida's message of "Mon, 17 Aug 2020 10:38:12 +0100") Message-ID: <87k0w9ozrz.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DATE_IN_PAST_12_24, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 21:53:06 -0000 Hello Giuliano, Giuliano Procida a =C3=A9crit: > Quite a while ago I had a series of patches with the aim of improving > libabigail's suppression parsing with the main aims: > > * adding error handling and reporting > * refactoring for easier maintenance (both fixes and features) > > Early on in the series, I changed the way regexes were parsed and > passed in and out of the suppression specifications. This wasn't > something you were happy with, so I shelved the series. > > I've taken a lttle time to remove those changes and rebase the series. > My plan is to feed changes to you in digistible batches. > > This batch contains: > > * 2 commits that fix issues in an uncontroversial way Thanks! I happily applied these. > * 3 commits to add the outer shell of error handling > * 2 commits to simplify how suppressions are constructed > > The error handling commits do not add any error reporting but do add > placeholder TODOs for where this could be added. > > The constructor change commits remove the non-default constructors for > the 4 suppression types as they are antithetical to a table-driver > parser where there are a large number of optional fields. I do really prefer that we keep recursive descent parsers in all the parsers of the project. Why? Because they are the simplest parsers to understand for someone who just wants to /debug/ it to fix things in the way the parser. Yes, they are more verbose and the grammar handling is hard coded. But that's a tradeoff I accept to keep the whole project as "debuggable" as it can be, given the inherent complexity of the core subject we are trying to tackle here. So, yeah, I am really not a fan for introducing a table-driven parser in this context at this point. [...] Cheers, --=20 Dodji