From: Dodji Seketeli <dodji@seketeli.org>
To: "Mark J. Wielaard" <mark@klomp.org>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH] dwarf-reader: Workaround libdw dwarf_location_expression bug
Date: Fri, 17 Dec 2021 19:47:24 +0100 [thread overview]
Message-ID: <87lf0j9igz.fsf@seketeli.org> (raw)
In-Reply-To: <20211215160021.24200-1-mark@klomp.org> (Mark J. Wielaard's message of "Wed, 15 Dec 2021 17:00:21 +0100")
Hello Mark,
"Mark J. Wielaard" <mark@klomp.org> a écrit:
> From: Mark Wielaard <mark@klomp.org>
>
> elfutils libdw before 0.184 would not correctly handle a
> DW_AT_data_member_location when encoded as a DW_FORM_implicit const
> in dwarf_location_expression.
>
> Work around this by first trying to read a data_member_location as a
> constant value and only try to get it as a DWARF expression if that
>
> * src/abg-dwarf-reader.cc (die_constant_data_member_location):
> New function.
> (die_member_offset): Use die_constant_data_member_location
> before calling die_location_expr and eval_quickly.
>
> Signed-off-by: Mark Wielaard <mark@klomp.org>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2021-12-17 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 15:55 Buildbot failure in Wildebeest Builder on whole buildset buildbot
2021-12-15 13:01 ` Mark Wielaard
2021-12-15 16:00 ` [PATCH] dwarf-reader: Workaround libdw dwarf_location_expression bug Mark J. Wielaard
2021-12-15 18:56 ` Giuliano Procida
2021-12-15 19:25 ` Mark J. Wielaard
2021-12-15 19:47 ` Thomas Schwinge
2021-12-17 18:47 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf0j9igz.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).