From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by sourceware.org (Postfix) with ESMTPS id 6EA65385041D for ; Tue, 4 Aug 2020 16:28:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6EA65385041D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 91A9220005; Tue, 4 Aug 2020 16:28:19 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 34F58180088E; Tue, 4 Aug 2020 18:28:18 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH v2] Fix maybe_report_data_members_replaced_by_anon_dm Organization: Me, myself and I References: <20200722105538.2543928-1-gprocida@google.com> <20200723083543.3143442-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.seketeli.net/~dodji Date: Tue, 04 Aug 2020 18:28:18 +0200 In-Reply-To: <20200723083543.3143442-1-gprocida@google.com> (Giuliano Procida's message of "Thu, 23 Jul 2020 09:35:42 +0100") Message-ID: <87lfiue5p9.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2020 16:28:23 -0000 Giuliano Procida a =C3=A9crit: [...] > > * src/abg-reporter-priv.cc > (maybe_report_data_members_replaced_by_anon_dm): Move > declarations of anonymous_data_member and > dms_replaced_by_same_anon_dm into inner loop. Use > anonymous_data_member for testing and reporting, allowing > iterators i and j to be replaced by just iterator i. Push > first decl onto dms_replaced_by_same_anon_dm unconditionally > and move control flow logic into loop condition. > * tests/data/Makefile.am: Add new test cases. > * tests/data/test-diff-filter/test-PR25661-7-report-1.txt: New > test case file. > * tests/data/test-diff-filter/test-PR25661-7-report-2.txt: > Likewise. > * tests/data/test-diff-filter/test-PR25661-7-report-3.txt: > Likewise. > * tests/data/test-diff-filter/test-PR25661-7-report-4.txt: > Likewise. > * tests/data/test-diff-filter/test-PR25661-7-v0.c: Likewise. > * tests/data/test-diff-filter/test-PR25661-7-v0.o: Likewise. > * tests/data/test-diff-filter/test-PR25661-7-v1.c: Likewise. > * tests/data/test-diff-filter/test-PR25661-7-v1.o: Likewise. > * tests/test-diff-filter.cc: Call new test cases. > > Signed-off-by: Giuliano Procida Applied to master, thanks! Cheers, --=20 Dodji