From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by sourceware.org (Postfix) with ESMTPS id 239AD386F821 for ; Mon, 20 Apr 2020 13:06:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 239AD386F821 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 2BB7320019; Mon, 20 Apr 2020 13:06:39 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 6383E581890; Mon, 20 Apr 2020 15:06:38 +0200 (CEST) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH] tests: parallelize diff-suppr test Organization: Me, myself and I References: <20200420102457.60986-1-maennich@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Mon, 20 Apr 2020 15:06:38 +0200 In-Reply-To: <20200420102457.60986-1-maennich@google.com> (Matthias Maennich's message of "Mon, 20 Apr 2020 12:24:57 +0200") Message-ID: <87lfmqe275.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 13:06:43 -0000 Matthias Maennich a =C3=A9crit: > Parallelize test execution for diff-suppr test by using abigail's multi > threaded worker queue. To accomplish that, follow a similar pattern like > other tests: Add a test_task struct with some precomputed values and > chunk up the work in main(). > > The test cases needed to be adjusted to allow parallel execution. In > particular the output files can't be shared anymore. To ensure this, a > small tests has been added that checks for unique output paths. > > Finally, one redundant test case has been dropped. > > This reduces the test time on my machine from ~31s to ~14s. There are > still two test cases that dominate the overall runtime. Since this test > is on the critical path for 'distcheck' (it is the test with the longest > runtime), this is effectively chopped off the overal make distcheck > time. > > * tests/test-diff-suppr.cc(main): parallelize test execution. > (test_task) new abigail::workers::task implementation to run > test cases in this test as separate worker tasks. Applied to master, thanks! Cheers, --=20 Dodji