From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by sourceware.org (Postfix) with ESMTPS id 4C4663858D37 for ; Wed, 30 Nov 2022 09:14:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C4663858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 81BE41BF20E; Wed, 30 Nov 2022 09:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1669799677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ymz0Gp0MQfx6l33XwhovIKxpS6FfBTFf3KOfjWHFRlI=; b=ns/zh0U1CgM54lNdcaE7znG1ihAfSVHm+cktpLZaVFyuqDwak9yqlpTU1GOEusQtS8Ewil Ih9JnIF7/cmoqhKi8fxIA9G05pHNjcK08V+4bfEf7NBV1W5MvFuunSFav7CF9RdPDyJ6tC KznuNGZbBEWps307NNuFkSpb2rkpYocsnuNkssHhL/54vZSpS20qBNgcJuW81lMpBLpqut Hh+HZewOrt5nlHY2pkyhiefBqVlEhtp0Ru6rgaw4zGv2IuYMLa4tLqaVum+cakfa/RPTLh dA6VmVbuDjlaspf5/hQiD8l70+o/XMCZHQ4Jpl+epamD1GubdJj79YG8v5wHDw== Received: by localhost (Postfix, from userid 1000) id CE51F581C5A; Wed, 30 Nov 2022 10:14:35 +0100 (CET) From: Dodji Seketeli To: "Guillermo E. Martinez" Cc: libabigail@sourceware.org, Dodji Seketeli Subject: Re: [PATCHv2 2/5]ctf-front-end: Fix size and name for underlying types Organization: Me, myself and I References: <87v8mxoo9g.fsf@seketeli.org> <20221129183222.420706-1-guillermo.e.martinez@oracle.com> X-Operating-System: Fedora 38 X-URL: http://www.seketeli.net/~dodji Date: Wed, 30 Nov 2022 10:14:35 +0100 In-Reply-To: <20221129183222.420706-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez's message of "Tue, 29 Nov 2022 12:32:22 -0600") Message-ID: <87mt88olc4.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Guillermo, "Guillermo E. Martinez" a =C3=A9crit: [...] > > * src/abg-ctf-reader.cc (process_ctf_{base_type,enum_type}): > Look at ctf refence type to build the underlying type if present. > * tests/data/Makefile.am: New test cases. > * tests/data/test-read-ctf/PR27700/test-PR27700.abi: New test input. > * tests/data/test-read-ctf/test-bitfield-enum.abi: Likewise. > * tests/data/test-read-ctf/test-bitfield-enum.c: Likewise. > * tests/data/test-read-ctf/test-bitfield-enum.o: Likewise. > * tests/data/test-read-ctf/test-bitfield.abi: Likewise. > * tests/data/test-read-ctf/test-bitfield.c: Likewise. > * tests/data/test-read-ctf/test-bitfield.o: Likewise. > * tests/data/test-read-ctf/test-enum-many.o.hash.abi: Adjust. > * tests/data/test-read-ctf/test-enum-symbol.o.hash.abi: Likewise. > * tests/data/test-read-ctf/test-enum.o.abi: Likewise: > * tests/data/test-read-ctf/test0.abi: Likewise. > * tests/data/test-read-ctf/test0.hash.abi: Likewise. > * tests/data/test-read-ctf/test1.so.abi: Likewise. > * tests/data/test-read-ctf/test1.so.hash.abi: Likewise. > * tests/data/test-read-ctf/test5.o.abi: Likewise. > * tests/test-read-ctf.cc: Update test suite. > > Signed-off-by: Dodji Seketeli > Signed-off-by: Guillermo E. Martinez Thanks! I haven't been clear in my message. The first part of the patch got committed already at https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommit;h=3D217f579bf788a= 11643c0066a7dc8aa76faa5a05d. It was only the testing part that was missing from that commit. That is why I sent you the missing (testing) part for review. Thanks again for reviewing it. I have thus applied that second part. It's at https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommit;h=3D5efe2247c3447= dc994a27dfe32e571023091213e. [...] Cheers, --=20 Dodji