From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by sourceware.org (Postfix) with ESMTPS id 57287384F48D for ; Fri, 18 Nov 2022 12:10:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 57287384F48D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 78B1D60005; Fri, 18 Nov 2022 12:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1668773447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S/6zbhewfUTIToABCdhdbFjP1t5PH0/Xg+s9MrSRkMY=; b=PPT3AZpFup9NyWUJjgSMs9TtKpPKlqrHazuqmfQdzy9qU6FZt7EtjYTTh1OyFJF9EjA/CM 2h+R0GeTy8AUPCJqas6UG4jDNyG4+fYK7smspO/8cTlQEoC9zxjIBv5X6UXdc6RPehvm+Z d/EqjTJ1Qte8a4F1gOIc0FmdjX0Paq1hKILXDkLSk9woN67L+iwHTgFbubRu/VhrV6X9e8 ZG7VtoD7AZ7rW+LszgSa+ofc9XOKPgbwhM/6BoQbW0joUWF6R2jeKPrjLIKplo4a/1rmwn 9Q1uzNhcVCJqO427v4aIW33bEbGIEUE1ZoR8Kz/tsCZJXKlv12Gj1TxqRFTCaA== Received: by localhost (Postfix, from userid 1000) id A0801581C5A; Fri, 18 Nov 2022 13:10:46 +0100 (CET) From: Dodji Seketeli To: Sam James Cc: Sam James via Libabigail Subject: Re: [PATCH] configure.ac: add dist-xz Organization: Me, myself and I References: <20221108073503.2609200-1-sam@gentoo.org> <9B665B0E-2AE8-471F-9B35-D2809DDEA35E@gentoo.org> <874juxoof0.fsf@seketeli.org> <37661221-AC5A-42D1-B63B-8FC1184368EB@gentoo.org> X-Operating-System: Fedora 38 X-URL: http://www.seketeli.net/~dodji Date: Fri, 18 Nov 2022 13:10:46 +0100 In-Reply-To: <37661221-AC5A-42D1-B63B-8FC1184368EB@gentoo.org> (Sam James's message of "Thu, 17 Nov 2022 16:22:51 +0000") Message-ID: <87mt8ompix.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Sam James a =C3=A9crit: [...] > I've tweaked it to take TARBALL as both .gz and .xz, but tbh, I think > we could very uncontroversially drop .gz too. A lot of software is .xz > only (like all of GNOME) and it doesn't really bother anyone. > > My gut is it's not worth adding additional machinery to allow > disabling xz creation because it kind of conflicts with the dist-* > stuff from automake (I think we could do it, but it's a bit awkward). > > The gzip creation is pretty cheap though. > > The libabigail tarball is by necessity quite large (which was the > motivation originally) so I think we have decent justification. > > TL;DR: I'll send a patch now with fixed TARBALL variable to include > both .gz and .xz but not sure it's worth the complexity to > allow specifically disabling either. If I had to choose, I'd just > drop gzip entirely given other projects do that fine without problems. OK, let's follow your gut feeling then :-) Your point of view seems sensible to me. My initial inclination seems overkill. I went ahead and applied your initial patch, in the form that I posted at the end of my previous message, to master. Thank you for your dedication. [...] Cheers, --=20 Dodji