From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by sourceware.org (Postfix) with ESMTPS id 645F63858010 for ; Wed, 4 May 2022 10:05:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 645F63858010 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 3914DFF810; Wed, 4 May 2022 10:05:42 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 83A5C5802BD; Wed, 4 May 2022 12:05:42 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, willdeacon@google.com Subject: Re: [PATCH 2/2] symtab: fix up 64-bit ARM address which may contain tags Organization: Me, myself and I References: <20220407162926.2076100-1-gprocida@google.com> <20220407162926.2076100-2-gprocida@google.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Wed, 04 May 2022 12:05:42 +0200 In-Reply-To: <20220407162926.2076100-2-gprocida@google.com> (Giuliano Procida's message of "Thu, 7 Apr 2022 17:29:26 +0100") Message-ID: <87mtfxehop.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 10:05:47 -0000 Hello Giuliano, Giuliano Procida a =C3=A9crit: > 64-bit ARM addresses normally have bits 47 to 63 as either all 0 or > all 1. If tagging is used, bits 56 to 63 can vary, but the > interpretation of such values is as if the bits were all the same as > bit 55. > > Such tagging is used for HWASAN and this affects the ELF symbol values > seen in shared libraries. > > This commit changes the interpretation of 64-bit ARM symbol values by > unconditionally extending bit 55 into bits 56 to 63. > > This fixes missing types for symbols in HWASAN-compiled libraries. > > * src/abg-elf-helpers.cc: (architecture_is_arm64): Add helper. > * src/abg-elf-helpers.h: Likewise. > * src/abg-symtab-reader.cc: (get_symbol_value): Adjust 64-bit > ARM symbol values by extending bit 55 into bits 56 to 63. > > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji