From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id 4F9803858038 for ; Fri, 10 Dec 2021 10:42:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F9803858038 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 25C2FFF80D; Fri, 10 Dec 2021 10:42:23 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 666485802BD; Fri, 10 Dec 2021 11:42:23 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 2/5] XML writer: use exemplar types for tracking referenced types Organization: Me, myself and I References: <20211203114622.2944173-1-maennich@google.com> <20211203114622.2944173-3-maennich@google.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Fri, 10 Dec 2021 11:42:23 +0100 In-Reply-To: <20211203114622.2944173-3-maennich@google.com> (Matthias Maennich's message of "Fri, 3 Dec 2021 11:46:20 +0000") Message-ID: <87mtl8rbao.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 10:42:30 -0000 Matthias Maennich a =C3=A9crit: > The emitted type sets are used with some referenced type sets (which use > bare type pointers). To keep consistency between what is being recorded > in each set, switch to storing exemplar type pointers in the referenced > type sets. > > This change results in the omission of a small number of duplicate > types from various test cases. In each case the duplicates were > previously caused by a referenced type being emitted for one > translation unit and then the same type being emitted as a canonical > type for a later translation unit. > > It also causes the movement of some function types in some test cases. > Some of those types are now considered referenced and appear earlier as > a result. > > * src/abg-writer.cc (record_type_as_referenced): Use preferred > type with referenced type sets. > (type_is_referenced): Likewise. > (tests/data/test-annotate/test14-pr18893.so.abi): Duplicate > type(s) removed, as described above. > (tests/data/test-read-dwarf/test14-pr18893.so.abi): Likewise. > (tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi= ): > Likewise. > (tests/data/test-read-dwarf/test16-pr18904.so.abi): Likewise. > (tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.a= bi): > Likewise. > (tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi): > Likewise. > (tests/data/test-read-dwarf/PR25007-sdhci.ko.abi): Some > function type(s) reordered, as described above. > (tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi): > Likewise. > (tests/data/test-annotate/test15-pr18892.so.abi):: Duplicate > type(s) removed and some function type(s) reordered, as > described above. > (tests/data/test-read-dwarf/test15-pr18892.so.abi): Likewise. > (tests/data/test-annotate/test21-pr19092.so.abi): Likewise. > (tests/data/test-read-dwarf/test21-pr19092.so.abi): Likewise > > Reviewed-by: Giuliano Procida > Signed-off-by: Matthias Maennich Applied to master, thanks! [...] Cheers, --=20 Dodji