From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 7D112385780A for ; Wed, 10 Nov 2021 12:09:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D112385780A Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AAAm6XC014410; Wed, 10 Nov 2021 12:09:01 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3c85nsagr9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Nov 2021 12:09:00 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AAC6IfJ108490; Wed, 10 Nov 2021 12:08:59 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by aserp3020.oracle.com with ESMTP id 3c5hh5603u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Nov 2021 12:08:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gV9zxwHvjTNVQt11HnHgoyfV73FTKsW0lJzU/489zziKHKf9A40xiNqMRNmaG33o3iDedDABo6ftSMLUFzM+NOwYA89Np/FXYM2fMvWoRPaq/vq4ZzdlogG+9DVwsyPB8UnC3bRLc6sZxoWK4ghB39z+Xn0Ka8vWOqkPb+EAWYGDLPKPLewBs6YvMmc+vTIe00+TjN07NETIVi4727DeHzAX8ixwjU0kDyRGfUukpriVkU1ioRN/KhS9FvVP/TG2+izz44hfOE/PeayxHBOgqvH7Vr4SC0k6JNfjl41Yo8rckjMhGzKMvyb1GeF3g93gPddlEMM/PQZ6vs6AupCENg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pw24xNnoJ0Rb/P1J7qC+H0WMu4kAMNayRBuE/edvF2A=; b=H6OCxgPo0NUNsoNNLfXF7v//2gVuWkxZYalVS96DMNpOOzcK9fsfuTwQb9LKVes0feZJaGhXvik6dRUaVrgECWVPUso1f1zpPpdaOGGtOSJsGtSSSB4qxH2I3tcdnGIEkafZXJIC08oc95j2Uo7PfzmOsN1iQShdz+z8rW95XKZPZ0tyS8tWm1DEbfUiNF+iFhzJ/of6pu6T42oGL17axopP94j95cxBG5hZvIo6i0OFjgLHHrEPrP7Ij38NVUKfH2FPmO5d5fCzfsDzTjiNhzSZYAMGdDQSFk3kDd5DVSYiud+hHCSDWq9ep9gdx2S6gNh5r5SuMWr+krXo2sHXiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BY5PR10MB4242.namprd10.prod.outlook.com (2603:10b6:a03:20d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Wed, 10 Nov 2021 12:08:57 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::48bf:86b4:32e1:6574]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::48bf:86b4:32e1:6574%4]) with mapi id 15.20.4669.016; Wed, 10 Nov 2021 12:08:57 +0000 From: "Jose E. Marchesi" To: Dodji Seketeli Cc: "Jose E. Marchesi via Libabigail" Subject: Re: [PATCH V2] ctf: make libabigail::ctf_reader::read_corpus reentrant References: <20211103135820.6233-1-jose.marchesi@oracle.com> <877ddh8vd7.fsf@seketeli.org> Date: Wed, 10 Nov 2021 13:08:50 +0100 In-Reply-To: <877ddh8vd7.fsf@seketeli.org> (Dodji Seketeli's message of "Tue, 09 Nov 2021 11:40:52 +0100") Message-ID: <87mtmc5i25.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM3PR07CA0071.eurprd07.prod.outlook.com (2603:10a6:207:4::29) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 Received: from termi.oracle.com (141.143.193.77) by AM3PR07CA0071.eurprd07.prod.outlook.com (2603:10a6:207:4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16 via Frontend Transport; Wed, 10 Nov 2021 12:08:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1d1d988-cf34-42f7-fd66-08d9a442df68 X-MS-TrafficTypeDiagnostic: BY5PR10MB4242: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f2F9hRjVaSbxZZ++mRovo9CCgKWkIY2fjtok/VfWgEdJuCy/zcmnKZEzwZauGL8pGMitYE9Aa7p4/KunowXfHOkHlqdZmLSsWxuPmnsaVM3DyDQnVsqLyzWJ+iZATK/dGrW2wNx0/Lp9p632iznHtykyk6ibR3pfps1bm2UZeAmvs8EFvpnnyeSjso7eMmbRaTrvb9rG0S5Xuv02syvwybTZH2QoWxTptMWJH0D7AwkgCeXsmh2ukQeb5lFdN10D0/FNcUUF5bXjB4WCfuI/cGsb1+bgbThnptYjNUe5nLZg5Pgtk39c3iB26PDAufcUV2ApPHUYx+aQ7HY8g/xD8YCo6Su02AKxIQ/m6dgP/S3/pZAyO3eSmRljgYudGtCM47ma1soVKyzrdWt6KFky6Ow1H+u9bUqpgGMIQw41lthhCT/inpVfvTyh3zxeEb5PBzzVWbpeNfwatjF7IZExCa+UHZqPHyiOw5fDLWykE6tkVN4JUcyiVEu4XJB5lxKsHwToN5YZIDjIiJrhYBjc0TEHSmaRFyMMP9Uzb3GOzlYwJcZAOzDsDvb27GHnfbJwGz2EgUj+rtY0dDfax+j+IuEMV9mjv5QhQNelF4DvLkzgEYDcLtuyW1L9QXntI9gJESgw9wlZfxM/8cu7Ezf13sCS1VBsd9bEYN1/kOpf3DHz0V6NQUM/nHXKgeCf5TzSyB7OYJhHSmLiyyqQCbKijg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(38100700002)(6666004)(38350700002)(86362001)(956004)(316002)(52116002)(26005)(7696005)(6486002)(2616005)(186003)(5660300002)(4326008)(66556008)(66476007)(36756003)(508600001)(83380400001)(66946007)(6916009)(8676002)(53546011)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2lnRXYwNVFGWkQyanlOWGlkK0QzSVRTTDNObHFKekVLb0NGd256WkhPSVBy?= =?utf-8?B?bVhCRi9ZNlhzVE5FQjliL2E1SUQ1dTViYklGdE9tMXlBUllURnlWNTU5RVZy?= =?utf-8?B?c1VCV3lpRzR0NkFGdFMrR3pqR3VsQkUrZDVxMC9KRDdLNWNiT2ZHWmFyTS9n?= =?utf-8?B?UFdVeEJtMEI1TTlQQmZhOUpOSEZ5Nnordy8yaEQwM0x6ZS9BaE1PYXMrMXYv?= =?utf-8?B?Wi9wbGY1a0xvbzY0VFZ4ZjgrUnZkeWRBNEY2QmRDL2lReWxVRU1jc1FvQ1pw?= =?utf-8?B?YmJaZHhOWDBsV0xuSGpMa0hrdlJPZzhRNU03aVFNSFNSLzI2OG5reDFJeHF6?= =?utf-8?B?QWRId2V3TlM4TytFM1NYVWRjdW8zU0YyYXNkaEFlVGZKajBxSDlQbExQaXIx?= =?utf-8?B?Y2FmeTBOeko5QkdUS0pRYWFoWXgzaEpacmNDRzJuMmtjRU44eEVZVmVWL29y?= =?utf-8?B?WGtPT3RGdUZ2SW4vOUJ0MkxYSC9kVE1OSloxcUxOREtiQ2l5bTdSYzBFdkM0?= =?utf-8?B?ZVZBRlZtOUJJVko3Z0Q0YzIwcFg0ZGNYdlRQUE42aWlZY3U2M1ZTVmpVNzlF?= =?utf-8?B?Y05DVHUrS3BXSjQ5Mnl0c0tpcEJCMHVHRkx2R3NlekRjcERBcWdYZXhBOEhX?= =?utf-8?B?Qnl6RDFtKzZGN3ZZWFVXNVhDRW0rMHlsWWRwckxzL3Z4NVpXRkFlVTdYaElS?= =?utf-8?B?b1piMXlPYmg2Z3JCVW1hWGlKZThiM0NCanBUZHR4UDAyR0lPMFlvV0RhbUQ4?= =?utf-8?B?bWxHMVc5RVZmUndFb0kxQ0xCNDNHYUFJS0NnK2dlMmFrMll6d3E2SUJPbS9k?= =?utf-8?B?U21JUS9KRGhBR2t4TkZnZHVEQnNEd2FLVjV4YU1iaTlxRzVvbUVWRzBmUENq?= =?utf-8?B?dkFGTFFwSGVCZTdQSGhCSUg3NzdUN0lob0RaVXNqYkZuOXRlT3NtemRFS2g3?= =?utf-8?B?M3NNdFowbjIrOSt6ZFZWcTVtcnppTEh2MkprN25Lak9NN0lXSHIwUkFBbmUz?= =?utf-8?B?ODJ3cmtGT2tzU0NaMElQaC9NdHltTGxuQUQxQ1ZEQUxSeFJSTEw3Y1VTMCtL?= =?utf-8?B?Nmc4YUNsQkNubUJWTzc1RWFMTXRvS3RjeWw0bHhGS2lxQTQwcGFhL2N0ZGdX?= =?utf-8?B?Mi8yMWhaaXZBZGVLWHJEVWZaSFpZbDFkSHAyQmo2NWtkUjJLZFZoVlRydG41?= =?utf-8?B?dkRGajhKTnBwZmFHb3dOd1BqRHQ2ampDUUJ6OUk1a3kwYWpLOXVKaDcrMmha?= =?utf-8?B?QkN4TGViMGJqQlBUVUF4ZERzSnphZk50ZTZxM3hBaVNaeEJvOFl0ZWRGZVN0?= =?utf-8?B?Szl2OGtUTnZaWkFiQnZleFVkNXBQa0haVXh1Q0x0aGhkWkZCVTErSkhsUFpw?= =?utf-8?B?STd4eTY3SWphbWZqZFhSTURYOVEyNnQwTzVqOVQ0NzdWYXhBWWJzTlVJK0NL?= =?utf-8?B?eHVBSkpnU0ltZjc4WnlNdmtENjcyMENvZXQyVDl5b2x0UFVUU2RpaE9jV2ZL?= =?utf-8?B?WWl0MzFlZTdXVk5BaHZrRUhMMWRFdE1QZkdRaUpjRGNiblozUDNjZ3puWC9v?= =?utf-8?B?WThRK2NYZjZPeTd5ZU1CNk9LOVByVlhuSzh1QU9DbzJ4U2QzYk50R0NwQXNJ?= =?utf-8?B?cy9RaFpYcTA3ZW4yQU5BN2ZGQjRYendmcmE2YjhTSWlkYUIyS2Z4TEJsUU14?= =?utf-8?B?dU1uUG14TXQ3ODZmSFNpeGpiMkwxZlpVMXRjS2NoY2JYR3dsL2trN1Y1U2tK?= =?utf-8?B?UHFXZkNmdW5abjFMV2RBay9lc0N4Snl6alVIbG9jU3hvRkd1aXJodXdXalc1?= =?utf-8?B?a0xmRlFnOERNYW52SGxJVEFHanFyNzh6UmZJWG1WSjhGWVFGekxWQUpLK3BU?= =?utf-8?B?d2lOV0lJblhLcnl5djAvYlV5U3BHK2dFM1hYRWh6aTRlMWVOYUxIMzJmYmE5?= =?utf-8?B?M3U5L1FzQndKK3VDZnVSRkc5WkQ3SWVnTjQ1WFFoK0hqcWlxZU9SMERmdGxv?= =?utf-8?B?NEl3bzl6a0FxaGhjSmRnd1hNLzRHblVLZW9pOHIxQTl0aGQzZXd3MzlSVVNN?= =?utf-8?B?MGlDSG5LMlU0Rk05OGVWT2pFdlRTdmpHeWhsbStieitZK2V4cUwwSXBZRHpE?= =?utf-8?B?VTM1a3ZMajZiN0ZmeFhWQ2FPNGkwMVMwcEtwcUNmNGRJeWRoTnBub0RLL2FQ?= =?utf-8?B?WHRlSFlTamJBMDVuQ244WXFFTVNPbEpvYjY2M0FYREFpc0t1RUxuN2JEYXln?= =?utf-8?Q?UyAAqcmvxno4pcQXbs1BFSu5W7bx+8HLJdsNMeK/cg=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1d1d988-cf34-42f7-fd66-08d9a442df68 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 12:08:57.4771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZNomXQukjqsOpmYwnNIH26z5sOsDzyrEXVNGrY6EDMtmwRkGk9jat6FNlBsIrXaRIIdDYtx55sgc6LDwxupiplbCuO5YXUyytEeHZDDKAuU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4242 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10163 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111100064 X-Proofpoint-GUID: l5ERKIaxxtgAuNxlBGFSpdL9cBrbmBXA X-Proofpoint-ORIG-GUID: l5ERKIaxxtgAuNxlBGFSpdL9cBrbmBXA X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 12:09:07 -0000 > "Jose E. Marchesi via Libabigail" a =C3=A9cri= t: > >> [Changes from V1: >> - Make sure that the string table passed to libctf is the one related >> to the symbol table.] > > > Pffft. > > I mistakenly applied the V1 patch to master, sorry about that. Nah it is my fault. I should have sent the right version straight away :) > So I am providing below a "differential" patch that would bring master > to the level of this V2 patch. > > Would you mind reviewing it, please, (and sign it off) so that I can > apply it master as well? LGTM. > > Thanks, and sorry again. > > Cheers, > > From b3e9ff53879939a3e0d4092ecd23cbd39393c268 Mon Sep 17 00:00:00 2001 > From: Dodji Seketeli > Date: Tue, 9 Nov 2021 11:24:16 +0100 > Subject: [PATCH] ctf-reader: Use the string table related to the symtab > > There can be several string tables in the ELF file. The one we want > to use is the one related to the symbol table, referred to by its > sh_link property. > > This patch ensures that. > > * src/abg-ctf-reader.cc (slurp_elf_info): Use the string table > related to the symbol table. > > Signed-off-by: Dodji Seketeli Signed-off-by: Jose E. Marchesi > --- > src/abg-ctf-reader.cc | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc > index 51fb2ed9..33642821 100644 > --- a/src/abg-ctf-reader.cc > +++ b/src/abg-ctf-reader.cc > @@ -1037,12 +1037,20 @@ slurp_elf_info(read_context *ctxt, corpus_sptr co= rp) > 0 /* No suppressions. */); > corp->set_symtab(ctxt->symtab); > =20 > - /* Get the raw ELF section contents for libctf. */ > + /* Get the raw ELF section contents for libctf. The .ctf section > + and the symtab are straightforward enough. */ > Elf_Scn *ctf_scn =3D elf_helpers::find_section(ctxt->elf_handler, ".ct= f", SHT_PROGBITS); > Elf_Scn *symtab_scn =3D elf_helpers::find_symbol_table_section(ctxt->e= lf_handler); > - Elf_Scn *strtab_scn =3D elf_helpers::find_section(ctxt->elf_handler, S= HT_STRTAB); > =20 > - if (ctf_scn =3D=3D NULL || symtab_scn =3D=3D NULL || strtab_scn =3D=3D= NULL) > + if (ctf_scn =3D=3D NULL || symtab_scn =3D=3D NULL) > + return 0; > + > + /* The string table that libctf expects is the one related to the > + symbol table by virtue of sh_link. */ > + GElf_Shdr symtab_shdr_mem, *symtab_shdr =3D gelf_getshdr(symtab_scn, &= symtab_shdr_mem); > + Elf_Scn *strtab_scn =3D elf_getscn(ctxt->elf_handler, symtab_shdr->sh_= link); > + > + if (strtab_scn =3D=3D NULL) > return 0; > =20 > fill_ctf_section(ctxt, ctf_scn, &ctxt->ctf_sect); > --=20 > > 2.32.0