From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id A85ED385040E for ; Mon, 19 Jul 2021 11:59:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A85ED385040E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 77B25FF804; Mon, 19 Jul 2021 11:59:45 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 11D02580100; Mon, 19 Jul 2021 13:59:42 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, david.marchand@redhat.com Subject: Re: [PATCH v2, applied] DWARF reader: fix bitfield offset calculations Organization: Me, myself and I References: <20210709231649.2969609-2-gprocida@google.com> <20210710165232.3071638-1-gprocida@google.com> X-Operating-System: Fedora 35 X-URL: http://www.seketeli.net/~dodji Date: Mon, 19 Jul 2021 13:59:42 +0200 In-Reply-To: <20210710165232.3071638-1-gprocida@google.com> (Giuliano Procida's message of "Sat, 10 Jul 2021 17:52:31 +0100") Message-ID: <87mtqiecpd.fsf_-_@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 11:59:49 -0000 Hello, Giuliano Procida a =C3=A9crit: > PR28060 - Invalid offset for bitfields I have put this as the summary of the patch to searching in the commit logs by bug number. > > Bitfield and other member offsets can be specified in DWARF using: > > - DW_AT_data_bit_offset, or > - DW_AT_data_member_location and optionally DW_AT_bit_offset. > > The code would only use the value DW_AT_data_member_location if there > was no DW_AT_bit_offset. This commit fixes this and adjusts > documentation and affected tests. > > * src/abg-dwarf-reader.cc (read_and_convert_DW_at_bit_offset): > Update documentation. > (die_member_offset): Treat DW_AT_bit_offset as an optional > adjustment to DW_AT_data_member_location. > * tests/data/test-annotate/test13-pr18894.so.abi: Update. > * tests/data/test-annotate/test15-pr18892.so.abi: Update. > * tests/data/test-annotate/test17-pr19027.so.abi: Update. > * tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.ab= i: > Update. > * tests/data/test-annotate/test21-pr19092.so.abi: Update. > * tests/data/test-diff-dwarf-abixml/PR25409-librte_bus_dpaa.so.20.0.abi: > Regenerate. > * tests/data/test-diff-pkg/libcdio-0.94-1.fc26.x86_64--libcdio-0.94-2.fc= 26.x86_64-report.1.txt: > Report now empty. > * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Update. > * tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi: > Update. > * tests/data/test-read-dwarf/test13-pr18894.so.abi: Update. > * tests/data/test-read-dwarf/test15-pr18892.so.abi: Update. > * tests/data/test-read-dwarf/test17-pr19027.so.abi: Update. > * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.= abi: > Update. > * tests/data/test-read-dwarf/test21-pr19092.so.abi: Update. > * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi: > Update. > > Signed-off-by: Giuliano Procida Applied to master. Thanks! [...] --=20 Dodji