From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net
 [217.70.183.194])
 by sourceware.org (Postfix) with ESMTPS id 30956386F82E
 for <libabigail@sourceware.org>; Wed, 22 Apr 2020 09:55:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 30956386F82E
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=dodji@seketeli.org
X-Originating-IP: 91.166.131.130
Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130])
 (Authenticated sender: dodji@seketeli.org)
 by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C970B40005;
 Wed, 22 Apr 2020 09:55:06 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id C41B2581891; Wed, 22 Apr 2020 11:55:05 +0200 (CEST)
From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org,  gprocida@google.com,  kernel-team@android.com
Subject: Re: [PATCH v2 7/8] abg-elf-helpers: migrate more elf helpers
 (architecture specific helpers)
Organization: Me, myself and I
References: <20200420110846.218792-1-maennich@google.com>
 <20200421063551.222511-1-maennich@google.com>
 <20200421063551.222511-8-maennich@google.com>
X-Operating-System: Fedora 33
X-URL: http://www.seketeli.net/~dodji
Date: Wed, 22 Apr 2020 11:55:05 +0200
In-Reply-To: <20200421063551.222511-8-maennich@google.com> (Matthias
 Maennich's message of "Tue, 21 Apr 2020 08:35:50 +0200")
Message-ID: <87mu73deva.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libabigail mailing list <libabigail.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2020 09:55:09 -0000

Matthias Maennich <maennich@google.com> a =C3=A9crit:

> This migrates more architecture specific helpers over to the
> elf-helpers. No functional change intended.
>
> 	* src/abg-dwarf-reader.cc(elf_architecture_is_ppc64): Move

I am adding a space here --------^

> 	function out and adjust callers to call the migrated
> 	functions.
> 	(elf_architecture_is_big_endian): Likewise.
> 	(architecture_word_size): Likewise.
> 	(current_elf_file_is_executable): Likewise.
> 	(current_elf_file_is_dso): Likewise.
> 	* src/abg-elf-helpers.cc (architecture_is_ppc64): Add new function.
> 	(architecture_is_big_endian): Likewise.
> 	(get_architecture_word_size): Likewise.
> 	(is_executable): Likewise.
> 	(is_dso): Likewise.
> 	* src/abg-elf-helpers.h (architecture_is_ppc64): Add new declaration.
> 	(architecture_is_big_endian): Likewise.
> 	(get_architecture_word_size): Likewise.
> 	(is_executable): Likewise.
> 	(is_dso): Likewise.

Applying to master with that change.

Cheers,

--=20
		Dodji