From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id A670F385BF83 for ; Tue, 14 Apr 2020 11:24:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A670F385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id DE55AFF804; Tue, 14 Apr 2020 11:24:32 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id EB2A4581890; Tue, 14 Apr 2020 13:24:31 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH 2/2] abidiff: Document and refresh tests. Organization: Me, myself and I References: <20200408122044.192132-1-gprocida@google.com> <20200408122044.192132-2-gprocida@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Tue, 14 Apr 2020 13:24:31 +0200 In-Reply-To: <20200408122044.192132-2-gprocida@google.com> (Giuliano Procida's message of "Wed, 8 Apr 2020 13:20:44 +0100") Message-ID: <87mu7enwcw.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 11:24:36 -0000 Giuliano Procida a =C3=A9crit: > Following on from giving some test file more descriptive names, this > patch actually documents in brief the purpose of these recently added > tests. > > It also improves the coverage of the test-leaf-cxx-members test to > include deletion and insertion report text as well. > > * tests/data/test-abidiff-exit/test-leaf-cxx-members-v1.cc: > Comment test. Reorder members of ops to get better coverage. > * tests/data/test-abidiff-exit/test-leaf-fun-type-v1.cc: > Comment test. > * tests/data/test-abidiff-exit/test-leaf-more-v1.cc: Ditto. > * tests/data/test-abidiff-exit/test-leaf-peeling-v1.cc: > Comment test. Update comment on ops2. > * tests/data/test-abidiff-exit/test-leaf-redundant-v1.c: > Comment test. > * tests/data/test-abidiff-exit/test-leaf-stats-v1.cc: Ditto. > * tests/data/test-abidiff-exit/test-leaf-cxx-members-report.txt: > Update locations. Update report to reflect deletion, > insertion and changed members (was previously changed only).: > * tests/data/test-abidiff-exit/test-leaf-peeling-report.txt: > Update locations. > * tests/data/test-abidiff-exit/test-leaf-redundant-report.txt: > Ditto.: > * tests/data/test-abidiff-exit/test-leaf-cxx-members-v0.cc: > Added one line comment referring to -v1 source file. > * tests/data/test-abidiff-exit/test-leaf-fun-type-v0.cc: Ditto. > * tests/data/test-abidiff-exit/test-leaf-more-v0.cc: Ditto. > * tests/data/test-abidiff-exit/test-leaf-peeling-v0.cc: Ditto. > * tests/data/test-abidiff-exit/test-leaf-redundant-v0.c: Ditto. > * tests/data/test-abidiff-exit/test-leaf-stats-v0.cc: Ditto. > * tests/data/test-abidiff-exit/test-leaf-cxx-members-v0.o: Recompiled. > * tests/data/test-abidiff-exit/test-leaf-cxx-members-v1.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-fun-type-v0.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-fun-type-v1.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-more-v0.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-more-v1.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-peeling-v0.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-peeling-v1.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-redundant-v0.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-redundant-v1.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-stats-v0.o: Ditto. > * tests/data/test-abidiff-exit/test-leaf-stats-v1.o: Ditto. Applied to master, thanks! Cheers, --=20 Dodji