From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay12.mail.gandi.net (relay12.mail.gandi.net
 [IPv6:2001:4b98:dc4:8::232])
 by sourceware.org (Postfix) with ESMTPS id D97D63858D37
 for <libabigail@sourceware.org>; Wed, 19 Jan 2022 10:39:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D97D63858D37
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
 by relay12.mail.gandi.net (Postfix) with ESMTPSA id E3252200005;
 Wed, 19 Jan 2022 10:38:58 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 37263581891; Wed, 19 Jan 2022 11:38:58 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org,  gprocida@google.com,  kernel-team@android.com
Subject: Re: [PATCH 5/5] XML writer: resolve declaration-only enum definitions
Organization: Me, myself and I
References: <20211203114622.2944173-1-maennich@google.com>
 <20211203114622.2944173-6-maennich@google.com>
X-Operating-System: Fedora 36
X-URL: http://www.seketeli.net/~dodji
Date: Wed, 19 Jan 2022 11:38:58 +0100
In-Reply-To: <20211203114622.2944173-6-maennich@google.com> (Matthias
 Maennich's message of "Fri, 3 Dec 2021 11:46:23 +0000")
Message-ID: <87o848au2l.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jan 2022 10:39:02 -0000

Matthias Maennich <maennich@google.com> a =C3=A9crit:

> Let the writer look through declaration-only enums for definitions.
>
> This matches what get_preferred_type, write_class_decl and
> write_union_decl do. No current test cases are affected.
>
> 	* src/abg-writer.cc (write_enum_type_decl): Look through
> 	declaration-only types the same as for structs and unions.
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>

Applied to master, thanks!

[...]

Cheers,

--=20
		Dodji