From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 501693858CDB for ; Thu, 2 Mar 2023 19:02:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 501693858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677783775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MwUuhq2umPRLlu9Po7QzW7NJWH/4Tov1mOq2e2CjHvY=; b=Ab8JytatghmR2qqYax+t5U9l2yKXMM3lc4gO+lo5oJ6aILsB9clb3GNmppRU0gM/C9ay28 KSEPinFulTQjsMelbR1elRLp3NOEsk/a9CrxGKwykVyJdkpHTt5gAhdlagAu1cdUNu1010 5sxafD5X6sj5pKe1DxPCbKWIPvAu5KI= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-613-n1xODIrNO2OFkK4kg2ph5g-1; Thu, 02 Mar 2023 14:02:54 -0500 X-MC-Unique: n1xODIrNO2OFkK4kg2ph5g-1 Received: by mail-qk1-f198.google.com with SMTP id s21-20020a05620a0bd500b0074234f33f24so7335qki.3 for ; Thu, 02 Mar 2023 11:02:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677783773; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MwUuhq2umPRLlu9Po7QzW7NJWH/4Tov1mOq2e2CjHvY=; b=euXXgaayrNibAB6YKApVSiSHk1jFuZFLUgLPPt1dgkDmyFB+pX+7sHRzs0qk936L60 0PY11BbffHfvczyZ2S1j+fgr1izJBxrGUbv7VFrymxjyifZ4W9JKnJMxm6aGClXLe+7n 7gCxHnNEy2egGV4PrMS4nPqUrBN7GF8VPsMgqkVzjFd0KK4fiiNPIxj9Pb+OzQ5pKmXO 4l+zATFdgInWbyi987VnDW3o7ukCcIiK9Ut9SywnHxH5xEbNnkE/11vNsmjROgdG2HlD PTZ9s9FuKamD+stqCC0O3fwgCwrB9dkpC1JspQWdGkU3cRPjW3PMXVj4emJAepM3Q4x2 Wdkw== X-Gm-Message-State: AO0yUKUmFmAHZkfFv3DUU34xJ4GsdD+ga9/w4uPtmdezveTWgzMoKiaa kLYPgHWcD+zH+tgu1VtGZBhf8YBwaslaqH8Ow+aPAPpfXL8e0keCoUumgp8JFF2NznWQuGYG3TC lBmeshOvfKWVn1acwrpP/ X-Received: by 2002:a05:622a:492:b0:3bf:d238:6ca with SMTP id p18-20020a05622a049200b003bfd23806camr15640999qtx.68.1677783773581; Thu, 02 Mar 2023 11:02:53 -0800 (PST) X-Google-Smtp-Source: AK7set9Umq58eeBDixwcd9TxslnRTXZ2GTtXrMGCaM8D8e/QosnvUyZKSW+5fU7oGNtv565C+Kaelw== X-Received: by 2002:a05:622a:492:b0:3bf:d238:6ca with SMTP id p18-20020a05622a049200b003bfd23806camr15640973qtx.68.1677783773295; Thu, 02 Mar 2023 11:02:53 -0800 (PST) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id t22-20020ac85316000000b003b9b8ec742csm256993qtn.14.2023.03.02.11.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 11:02:52 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id 64563581C79; Thu, 2 Mar 2023 20:02:51 +0100 (CET) From: Dodji Seketeli To: Dodji Seketeli Cc: libabigail@sourceware.org, ckalina@redhat.com Subject: [PATCH 10/13] comp-filter: Don't re-visit node while applying filters to diff nodes Organization: Red Hat / France References: <877cvzrnws.fsf@redhat.com> <87356nrnmq.fsf@redhat.com> X-Operating-System: Fedora 38 X-URL: http://www.redhat.com Date: Thu, 02 Mar 2023 20:02:51 +0100 In-Reply-To: <87356nrnmq.fsf@redhat.com> (Dodji Seketeli's message of "Thu, 02 Mar 2023 19:53:17 +0100") Message-ID: <87pm9rou1w.fsf_-_@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, When applying a filter to a corpus_diff node, visit each diff node only once. This can have some serious performance impact when there are a lot of diff nodes to visit. * src/abg-comp-filter.cc (apply_filter): In the overload for corpus_diff, visit each diff node only once. Signed-off-by: Dodji Seketeli --- src/abg-comp-filter.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/abg-comp-filter.cc b/src/abg-comp-filter.cc index 83c406cf..5300d07c 100644 --- a/src/abg-comp-filter.cc +++ b/src/abg-comp-filter.cc @@ -41,7 +41,7 @@ void apply_filter(filter_base& filter, corpus_diff_sptr d) { bool s = d->context()->visiting_a_node_twice_is_forbidden(); - d->context()->forbid_visiting_a_node_twice(false); + d->context()->forbid_visiting_a_node_twice(true); d->traverse(filter); d->context()->forbid_visiting_a_node_twice(s); } -- 2.39.2 -- Dodji