From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id 508E83858D1E for ; Wed, 21 Dec 2022 13:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 508E83858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 72D64FF812; Wed, 21 Dec 2022 13:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1671629680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/2utNZIE6x0LEuIQpVXD4wPNPMCPsM1jKUy7nCPfKc=; b=Gv3mZ+uLuUnSon74y2fUclsYiVe+GDhvUmVTYvI/x5yNevTILQ98ggeTZvYO9F49qW9yju /9Jzr7WqwGzL+0I9vaqhX3A/+taffj9FOYsh3bTSWMZCOu7/jgdnajqLypXG6ke0AQzHfr i6u1gTovcFzE626dWeECbnJLS1AyTPaJu1r1faG8KM0kvVXqG7JhgdXzEAudA1fkk+LoAT oe38wjLrtiVvwAd0NjRORWljznk3+x+4xHMszpON33rz3PC04p9MEgOCsAWt3FDTUDyNVM k8u6FdgwMtH0U63ExdT1JMAR3DnAOybbN4SJZAXTuRJrY/fiarg1VZkljiD7wA== Received: by localhost (Postfix, from userid 1000) id 5C8B5B5649; Wed, 21 Dec 2022 14:22:02 +0100 (CET) From: Dodji Seketeli To: "Guillermo E. Martinez via Libabigail" Cc: "Guillermo E. Martinez" Subject: Re: [PATCH] ctf-front-end: Add test for alias symbols Organization: Me, myself and I References: <87zgcpmz19.fsf@seketeli.org> <20221118215512.612834-1-guillermo.e.martinez@oracle.com> X-Operating-System: CentOS Stream release 9 X-URL: http://www.seketeli.net/~dodji Date: Wed, 21 Dec 2022 14:22:02 +0100 In-Reply-To: <20221118215512.612834-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Fri, 18 Nov 2022 15:55:12 -0600") Message-ID: <87pmccdh8l.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Guillermo, "Guillermo E. Martinez via Libabigail" a =C3=A9crit: > Hello, > > Any comment about this patch? Ah, oops, it looks like it felt through the cracks, sorry about that. I have reviewed it just now, please see my comments below. [...] "Guillermo E. Martinez via Libabigail" a =C3=A9crit: > This patch add a new test case in the ctf-front-end test suite to > to test for alias symbols. OK. So I have updated the patch to make it apply to my tree as it wouldn't apply due to obvious divergences. Also, I have added a ChangeLog compatible paragraph to the commit log. Could you please add a "signed-off" to the resulting patch below, so that I can apply it? Thanks! >From 22ee2da3dc78cbf055f400139d0a4ca467e0a294 Mon Sep 17 00:00:00 2001 From: "Guillermo E. Martinez" Date: Sun, 20 Nov 2022 21:46:15 -0600 Subject: [PATCH] ctf-front-end: Add test for alias symbols This patch adds a new test case in the ctf-front-end test suite to to test for alias symbols support. * tests/data/test-read-ctf/test-alias.o: New binary test input file. * tests/data/test-read-ctf/test-alias.o.abi: New exported abixml file. * tests/data/Makefile.am: Add the new test input above * tests/test-read-ctf.cc: Add the new test input above to the test harness. Signed-off-by: Dodji Seketeli --- tests/data/Makefile.am | 1 + tests/data/test-read-ctf/test-alias.o | Bin 0 -> 1664 bytes tests/data/test-read-ctf/test-alias.o.abi | 16 ++++++++-------- tests/test-read-ctf.cc | 8 ++++++++ 4 files changed, 17 insertions(+), 8 deletions(-) create mode 100644 tests/data/test-read-ctf/test-alias.o diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am index e994aff3..0f1f4e26 100644 --- a/tests/data/Makefile.am +++ b/tests/data/Makefile.am @@ -643,6 +643,7 @@ test-read-ctf/test9.c \ test-read-ctf/test9.o \ test-read-ctf/test9.o.abi \ test-read-ctf/test-alias.c \ +test-read-ctf/test-alias.o \ test-read-ctf/test-alias.o.abi \ test-read-ctf/test-ambiguous-struct-A.c \ test-read-ctf/test-ambiguous-struct-A.o \ diff --git a/tests/data/test-read-ctf/test-alias.o b/tests/data/test-read-c= tf/test-alias.o new file mode 100644 index 0000000000000000000000000000000000000000..18549b793a81754d6bc319eaa0f= 46179a4686b49 GIT binary patch literal 1664 zcmbtUv2GJV5S??36TpcQgb-3da-fJK@SbfX1SycgfFpz`5GkW*@4SvrobRl=3DO|WU8 zLZZtjQ1S_sNc;dL9Tgt{H4@CMcfekZC>UvOX5Y-4_3hj9i+d067d#KxJh%nFSBwI* z7N&BOwqO~`u)Fj6%kka^`1ZM2;EqjBFfO5&(a)lvN3WtkLD%TC4>^rKfxd!%(MG}v z;~q>)MSN5cqB&@#NdS*HXy?oih!PD0872EiG6NY$GB?>#8g(al?=3DT6$@23Oh2jgJu zry)G$59}I=3Ds-qsEm6;W;cJ!a-0w;)O}<%YS3} zH?THsE`JY;bf&H8Cd}X2f%d-+P9a8I<}*HTZyNQPx# literal 0 HcmV?d00001 diff --git a/tests/data/test-read-ctf/test-alias.o.abi b/tests/data/test-re= ad-ctf/test-alias.o.abi index 1fe61b8f..b5fd92ad 100644 --- a/tests/data/test-read-ctf/test-alias.o.abi +++ b/tests/data/test-read-ctf/test-alias.o.abi @@ -1,19 +1,19 @@ - + - + - - - + + + - - - + + + diff --git a/tests/test-read-ctf.cc b/tests/test-read-ctf.cc index 236ccbf2..f618e0fd 100644 --- a/tests/test-read-ctf.cc +++ b/tests/test-read-ctf.cc @@ -335,6 +335,14 @@ static InOutSpec in_out_specs[] =3D "output/test-read-ctf/test-linux-module.abi", "--ctf" }, + { + "data/test-read-ctf/test-alias.o", + "", + "", + SEQUENCE_TYPE_ID_STYLE, + "data/test-read-ctf/test-alias.o.abi", + "output/test-read-ctf/test-alias.o.abi", + }, // CTF fallback feature. { "data/test-read-ctf/test-fallback.o", --=20 2.31.1 --=20 Dodji