Re: [PATCHv3] ELF based front-end readers fallback feature

[Dodji Seketeli <dodji@seketeli.org>]

Hello Guillermo,

"Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
écrit:

[...]

> 	* doc/manuals/abidiff.rst: Adjust usage tool information
> 	to indicates fallback for CTF debug info when DWARF info
> 	is not present.
> 	* doc/manuals/abidw.rst: Likewise.
> 	* doc/manuals/abipkgdiff.rst: Likewise.
> 	* doc/manuals/kmidiff.rst: Likewise.
> 	* include/abg-elf-based-reader.h (initialize): Add member function.
> 	* include/abg-elf-reader.h (has_{dwarf,ctf}_debug_info): Add predicate
> 	functions.
> 	* include/abg-tools-utils.h (create_best_elf_based_reader): Add arguments.
> 	* src/abg-ctf-reader.cc (process_ctf_typedef, process_ctf_base_type)
> 	(process_ctf_function_type, process_ctf_sou_members, process_ctf_forward_type)
> 	(process_ctf_struct_type, process_ctf_union_type, process_ctf_array_type)
> 	(process_ctf_qualified_type, process_ctf_pointer_type, process_ctf_enum_type):
> 	Remove arguments. Using getters to access required information instead.
> 	(reader::cur_tu_): Add data member.
> 	(initialize): Add arguments.
> 	(cur_transl_unit): Add {get,set)ter.
> 	(slurp_elf_info): Clear `STATUS_DEBUG_INFO_NOT_FOUND' if corpus is
> 	`LINUX_KERNEL_BINARY_ORIGIN'.
> 	(reader::lookup_type): Remove.
> 	(reader::build_type): New member function.
> 	* src/abg-elf-reader.cc (reader::reader): Locate ctf debug info from binary file.
> 	(reader::reader): Reset base `fe_iface' constructor.
> 	(reader::has_{dwarf,ctf}_debug_info): New definitions.
> 	(reader::read_corpus): Set `STATUS_DEBUG_INFO_NOT_FOUND' according to corpus::origin.
> 	* src/abg-tools-utils.cc (dir_contains_ctf_archive): Define new member.
> 	(file_has_ctf_debug_info): Looks for kernel ctf debug information archive.
> 	(maybe_load_vmlinux_{dwarf,ctf}_corpus): Remove.
> 	(load_vmlinux_corpus): Define function to load IR from kernel regardless the
> 	corpus::origin.
> 	(build_corpus_group_from_kernel_dist_under): Make use of
> 	`create_best_elf_based_reader'
> 	to select the front-end.
> 	(create_best_elf_based_reader): Adjust to allow fallback behaviour for different
> 	front-ends.
> 	* tests/data/Makefile.am: Add tests.
> 	* tests/data/test-diff-pkg-ctf/dirpkg-3-report-2.txt: Adjust.
> 	* tests/data/test-read-ctf/test-fallback.abi: New test case.
> 	* tests/data/test-read-ctf/test-fallback.c: Likewise.
> 	* tests/data/test-read-ctf/test-fallback.o: Likewise.
> 	* tests/data/test-read-dwarf/test-fallback.abi: Likewise.
> 	* tests/data/test-read-dwarf/test-fallback.c: Likewise.
> 	* tests/data/test-read-dwarf/test-fallback.o: Likewise.
> 	* tests/test-diff-pkg.cc: Adjust.
> 	* tests/test-read-common.cc (test_task::run_abidw): Use of `options:option' field.
> 	* tests/test-read-common.h (InOutSpec): Add new member.
> 	* tests/test-read-ctf.cc (in_out_specs): Add option field to test suite.
> 	Add new test case.
> 	* tests/test-read-dwarf.cc: Likewise.
> 	* tools/abidiff.cc (main): Use `create_best_elf_based_reader'.
> 	* tools/abidw.cc: Likewise.
> 	* tools/abipkgdiff.cc: Likewise.

It looks like the patch lacks the file
tests/data/test-read-dwarf/test-fallback.o.  Here is what I am getting
when I do "make distcheck-fast":

make[7]: *** No rule to make target 'test-read-dwarf/test-fallback.o', needed by 'distdir-am'.  Stop.

[...]

Cheers,

-- 
		Dodji