From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by sourceware.org (Postfix) with ESMTPS id 8E18C3858C50 for ; Tue, 22 Nov 2022 14:19:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E18C3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 2B4D71BF20B; Tue, 22 Nov 2022 14:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1669126771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IM/aT3e+ZkJVCCEMu4rT1XLt3p5lyMgR2ucM2NVH75c=; b=Dolz/mVXvCLHaJBtwi1f7xHzjlBLj/j2RPgG4QfjFPTfco1dh7SdldRJTfEP81DvR5Etyu I5F548wNziw+hOxxuoX+/gTGinzb3pGnYYUtMrX2Ya0sg+kJXuUQi+DePaNgvNqp22ZBP9 eBaZm42vuM50l2DCKrxbCMV2sgNlt4KAzXfMfGv4f4hlJdOo371P/RRZQOIQVXBT9p3uVv 1MUIJMoA1wx404I7gb1ZyRM7VBUVA54Z/aWa4JRyvfgUxJtLMGKqf7sewS74Hwk5799HIQ +IKk5U+bcxNA7kc59mm2FK9mHG9MiaMjPMVMF+D66Tkqbp1yxGxA936ugLkP3g== Received: by localhost (Postfix, from userid 1000) id 020D3581C59; Tue, 22 Nov 2022 15:19:29 +0100 (CET) From: Dodji Seketeli To: "Guillermo E. Martinez via Libabigail" Cc: "Guillermo E. Martinez" Subject: Re: [PATCHv3] ELF based front-end readers fallback feature Organization: Me, myself and I References: <20221115201338.2149438-1-guillermo.e.martinez@oracle.com> <20221121185102.1163007-1-guillermo.e.martinez@oracle.com> X-Operating-System: Fedora 38 X-URL: http://www.seketeli.net/~dodji Date: Tue, 22 Nov 2022 15:19:29 +0100 In-Reply-To: <20221121185102.1163007-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Mon, 21 Nov 2022 12:51:02 -0600") Message-ID: <87pmdfoyvi.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Guillermo, "Guillermo E. Martinez via Libabigail" a =C3=A9crit: [...] > * doc/manuals/abidiff.rst: Adjust usage tool information > to indicates fallback for CTF debug info when DWARF info > is not present. > * doc/manuals/abidw.rst: Likewise. > * doc/manuals/abipkgdiff.rst: Likewise. > * doc/manuals/kmidiff.rst: Likewise. > * include/abg-elf-based-reader.h (initialize): Add member function. > * include/abg-elf-reader.h (has_{dwarf,ctf}_debug_info): Add predicate > functions. > * include/abg-tools-utils.h (create_best_elf_based_reader): Add argument= s. > * src/abg-ctf-reader.cc (process_ctf_typedef, process_ctf_base_type) > (process_ctf_function_type, process_ctf_sou_members, process_ctf_forward= _type) > (process_ctf_struct_type, process_ctf_union_type, process_ctf_array_type) > (process_ctf_qualified_type, process_ctf_pointer_type, process_ctf_enum_= type): > Remove arguments. Using getters to access required information instead. > (reader::cur_tu_): Add data member. > (initialize): Add arguments. > (cur_transl_unit): Add {get,set)ter. > (slurp_elf_info): Clear `STATUS_DEBUG_INFO_NOT_FOUND' if corpus is > `LINUX_KERNEL_BINARY_ORIGIN'. > (reader::lookup_type): Remove. > (reader::build_type): New member function. > * src/abg-elf-reader.cc (reader::reader): Locate ctf debug info from bin= ary file. > (reader::reader): Reset base `fe_iface' constructor. > (reader::has_{dwarf,ctf}_debug_info): New definitions. > (reader::read_corpus): Set `STATUS_DEBUG_INFO_NOT_FOUND' according to co= rpus::origin. > * src/abg-tools-utils.cc (dir_contains_ctf_archive): Define new member. > (file_has_ctf_debug_info): Looks for kernel ctf debug information archiv= e. > (maybe_load_vmlinux_{dwarf,ctf}_corpus): Remove. > (load_vmlinux_corpus): Define function to load IR from kernel regardless= the > corpus::origin. > (build_corpus_group_from_kernel_dist_under): Make use of > `create_best_elf_based_reader' > to select the front-end. > (create_best_elf_based_reader): Adjust to allow fallback behaviour for d= ifferent > front-ends. > * tests/data/Makefile.am: Add tests. > * tests/data/test-diff-pkg-ctf/dirpkg-3-report-2.txt: Adjust. > * tests/data/test-read-ctf/test-fallback.abi: New test case. > * tests/data/test-read-ctf/test-fallback.c: Likewise. > * tests/data/test-read-ctf/test-fallback.o: Likewise. > * tests/data/test-read-dwarf/test-fallback.abi: Likewise. > * tests/data/test-read-dwarf/test-fallback.c: Likewise. > * tests/data/test-read-dwarf/test-fallback.o: Likewise. > * tests/test-diff-pkg.cc: Adjust. > * tests/test-read-common.cc (test_task::run_abidw): Use of `options:opti= on' field. > * tests/test-read-common.h (InOutSpec): Add new member. > * tests/test-read-ctf.cc (in_out_specs): Add option field to test suite. > Add new test case. > * tests/test-read-dwarf.cc: Likewise. > * tools/abidiff.cc (main): Use `create_best_elf_based_reader'. > * tools/abidw.cc: Likewise. > * tools/abipkgdiff.cc: Likewise. It looks like the patch lacks the file tests/data/test-read-dwarf/test-fallback.o. Here is what I am getting when I do "make distcheck-fast": make[7]: *** No rule to make target 'test-read-dwarf/test-fallback.o', need= ed by 'distdir-am'. Stop. [...] Cheers, --=20 Dodji