From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH, applied] ir: Fix a wrong comment in canonicalize()
Date: Mon, 10 Oct 2022 13:58:25 +0200 [thread overview]
Message-ID: <87pmez28m6.fsf@redhat.com> (raw)
Hello,
While looking at something else, I noticed a comment that doesn't make
sense in the canonicalize() Fixed thus.
* src/abg-ir.cc (canonicalize): Fix a comment.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
src/abg-ir.cc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index e6b8409a..2fc7e747 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -14673,8 +14673,10 @@ canonicalize(type_base_sptr t)
// comparison of another type that was being canonicalized
//
// 2/ Or the canonical type has been propagated during the
- // comparison of another type was being canonicalized and that
- // propagated canonical type has been confirmed.
+ // comparison of another type that was being canonicalized and
+ // that propagated canonical type has been confirmed, because
+ // it was depending on a recursive type which comparison
+ // succeeded.
ABG_ASSERT(!t->priv_->canonical_type_propagated()
|| t->priv_->propagated_canonical_type_confirmed());
--
2.38.0.rc2
--
Dodji
reply other threads:[~2022-10-10 11:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmez28m6.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).