From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by sourceware.org (Postfix) with ESMTPS id C017F3858004 for ; Tue, 16 Mar 2021 10:59:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C017F3858004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodji@seketeli.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 04D4420011; Tue, 16 Mar 2021 10:59:20 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 4646058000E; Tue, 16 Mar 2021 11:59:20 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 12/20] abg-elf-helpers: migrate ppc64 specific helpers Organization: Me, myself and I References: <20200619214305.562-1-maennich@google.com> <20210127125853.886677-1-maennich@google.com> <20210127125853.886677-13-maennich@google.com> X-Operating-System: Fedora 34 X-URL: http://www.seketeli.net/~dodji Date: Tue, 16 Mar 2021 11:59:20 +0100 In-Reply-To: <20210127125853.886677-13-maennich@google.com> (Matthias Maennich's message of "Wed, 27 Jan 2021 12:58:45 +0000") Message-ID: <87pmzzxt2v.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 10:59:24 -0000 Hello, Matthias Maennich a =C3=A9crit: [...] > diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc > index 693fae82040e..b2a7144afe9d 100644 > --- a/src/abg-dwarf-reader.cc > +++ b/src/abg-dwarf-reader.cc [...] > /// Test if a given function symbol has been exported. > /// > /// @param symbol_address the address of the symbol we are looking > @@ -5890,13 +5726,15 @@ public: > // symbol that are in the .opd section. > GElf_Addr fn_desc_addr =3D sym->st_value; > GElf_Addr fn_entry_point_addr =3D > - lookup_ppc64_elf_fn_entry_point_address(fn_desc_addr); > + lookup_ppc64_elf_fn_entry_point_address( > + elf_handle(), fn_desc_addr); Please put the opening parenthesis of the function call on the new line. [...] > * src/abg-dwarf-reader.cc (read_context::opd_section_): Delete. > (read_context::find_opd_section): Delete. > (read_context::read_uint64_from_array_of_bytes): Delete. > (read_context::read_int_from_array_of_bytes): Delete. > (read_context::lookup_ppc64_elf_fn_entry_point_address): Delete. > (read_context::address_is_in_opd_section): Delete. > (read_context::address_is_in_section): Delete. > (read_context::load_symbol_maps_from_symtab_section): Adjust. > * src/abg-elf-helpers.cc (read_int_from_array_of_bytes): New. > (read_uint64_from_array_of_bytes): New. > (lookup_ppc64_elf_fn_entry_point_address): New. > (address_is_in_section): New. > (address_is_in_opd_section): New. > * src/abg-elf-helpers.h > (lookup_ppc64_elf_fn_entry_point_address): New declaration. > (address_is_in_opd_section): New declaration. > > Reviewed-by: Giuliano Procida > Signed-off-by: Matthias Maennich OK to apply to master with the above change once the prerequisite patches are applied. Thanks! [...] Cheers, --=20 Dodji