From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, gprocida@google.com,
kernel-team@android.com
Subject: Re: [PATCH] abg-dwarf-reader: simplify symbol map update
Date: Mon, 20 Apr 2020 14:53:00 +0200 [thread overview]
Message-ID: <87pnc2e2tv.fsf@seketeli.org> (raw)
In-Reply-To: <20200420074311.92426-1-maennich@google.com> (Matthias Maennich's message of "Mon, 20 Apr 2020 09:43:11 +0200")
Matthias Maennich <maennich@google.com> a écrit:
> For the update of fun_syms_, undefined_fun_syms_, var_syms_,
> undefined_var_syms_, there is a pattern in
> read_context::load_symbol_maps_from_symtab_section that can be
> simplified: We try to find the correct entry and keep the iterator. If
> we do not find it, we construct the value vector, find it again and
> update the iterator. Eventually we push_back the symbol. That can be
> simplified to looking up the value with operator[], which either returns
> the existing value or default constructs it. The reference returned is
> good for the push_back in any case.
>
> * src/abg-dwarf-reader.cc
> (read_context::load_symbol_maps_from_symtab_section): simplify
> symbol map update for fun_syms_, undefined_fun_syms_, var_syms_,
> undefined_var_syms_.
Applied to master, thanks!
Cheers,
--
Dodji
prev parent reply other threads:[~2020-04-20 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 7:43 Matthias Maennich
2020-04-20 8:11 ` Giuliano Procida
2020-04-20 12:53 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnc2e2tv.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).