From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230]) by sourceware.org (Postfix) with ESMTPS id 4F0043858C51 for ; Tue, 17 May 2022 07:11:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F0043858C51 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 21C74240002; Tue, 17 May 2022 07:11:28 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 4813A581C3E; Tue, 17 May 2022 09:11:28 +0200 (CEST) From: Dodji Seketeli To: "Guillermo E. Martinez" Cc: libabigail@sourceware.org Subject: Re: [PATCH] abipkgdiff: Add support to compare packages with CTF debug format Organization: Me, myself and I References: <20220507020326.1417379-1-guillermo.e.martinez@oracle.com> <875ym5uo28.fsf@seketeli.org> <2710573.BEx9A2HvPv@sali> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Tue, 17 May 2022 09:11:28 +0200 In-Reply-To: <2710573.BEx9A2HvPv@sali> (Guillermo E. Martinez's message of "Mon, 16 May 2022 17:21:06 -0500") Message-ID: <87r14styzj.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 07:11:33 -0000 Hello Guillermo, "Guillermo E. Martinez" a =C3=A9crit: [...] >> abigail::ctf_reader::create_read_context only takes two parameters: >> elf1.path and env.get(). So I removed the di_dirs1 one. > Oh, this is because there is a previous patch to use the `di_dirs1' param= eters: > https://sourceware.org/pipermail/libabigail/2022q2/004361.html[1] > my fault, for get mentioned it. No problem, I'll look at that one, apply it, and perform the necessary modifications. Maybe in the future, if you have patches that depends on each other like that, it's better to post a complete patch-set, rather than posting them one by one? In any case, thank you for working on this, it's appreciated. [...] Cheers, --=20 Dodji