From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by sourceware.org (Postfix) with ESMTPS id D11C03858414 for ; Fri, 25 Feb 2022 09:37:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D11C03858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id A84A72000B; Fri, 25 Feb 2022 09:37:05 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 3DCB35802B4; Fri, 25 Feb 2022 10:37:05 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH 1/4] XML writer: remove type_hasher and remaining comment Organization: Me, myself and I References: <20220121173005.3196387-1-gprocida@google.com> <20220121173005.3196387-2-gprocida@google.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Fri, 25 Feb 2022 10:37:05 +0100 In-Reply-To: <20220121173005.3196387-2-gprocida@google.com> (Giuliano Procida's message of "Fri, 21 Jan 2022 17:30:02 +0000") Message-ID: <87r17rl22m.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 09:37:09 -0000 Giuliano Procida a =C3=A9crit: > The type_hasher functor is no longer used. > > * src/abg-writer.cc (type_hasher): Remove this unused functor. > Remove a following comment referencing it. > > Reviewed-by: Matthias Maennich > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji