From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 1B0E63857C6C for ; Wed, 10 Nov 2021 12:06:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1B0E63857C6C Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AAAm6VZ014410; Wed, 10 Nov 2021 12:06:43 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3c85nsagcm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Nov 2021 12:06:43 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AAC67p8021864; Wed, 10 Nov 2021 12:06:42 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by aserp3030.oracle.com with ESMTP id 3c5frfg6ph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Nov 2021 12:06:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qt1UJSpqQVDsZ7J3aTfIbykLEEiVtC3BFqGh/J9/h2G8jk+WqF65vlggUXPVpzYToTTZwWx9zg4ZhtRjkVEBJ7tO3bwkDrPNVg2Xg9A1fk5wpbk4Pb5t1njGh3IrXpUx0FP1Pee1OGpDFP42/ixFTwE1or1wAsBk2mGH51KaYnT66MU2jzu3aC4Qld+2V+GUorFlm9a01BbMXF9bjUg4iMknkbm4xp/mgq8f4J+vxFFvwMoWLL9P7+vD0YJ9aQ96rVS9DAofmph2Xhl6GFWWoh0male35IsBqOtEjxSIZYPPcGONJfuFXqM6LYcssLy6S5LYtaV/f02lRHSy0d1Nuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eCVP9qErZz8XY91lt7BkBWsaGpB94HH7v0WZUl/cZaY=; b=LN+AMUZulckrJkcGgQ4pcaEIdTVF8IUyDaWchLCno5GrlenXXeGvZaCddUG3aeP7pH0IApAeuxS0WxocygzuADpVCbMoSvZSCj5KbbUeqphkQ+1V7tPOwReJBBUu+lNGZ6HuNGTL6nNZ6fz308eZgOrb2YaEaCaEP55VD/hvGa8kvly58MFjSsfItcUmMjmVICGwJl/VmIjbixn7DtI4Gn13Ni/0IPIHgHyg/Ge7tOL5JXhZ4JXfJsPfDj0miXd0j+/bXLyqy4jEIzRZqvsVMU+cRyTFUE//eEsclbfWA4Ts018MJ+ZYpd0M65mx+/IrvHgghlUclKVWAcrfNcIsLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BY5PR10MB4242.namprd10.prod.outlook.com (2603:10b6:a03:20d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Wed, 10 Nov 2021 12:06:40 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::48bf:86b4:32e1:6574]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::48bf:86b4:32e1:6574%4]) with mapi id 15.20.4669.016; Wed, 10 Nov 2021 12:06:40 +0000 From: "Jose E. Marchesi" To: Dodji Seketeli Cc: Guillermo Martinez via Libabigail , Guillermo Martinez Subject: Re: Regression tests for ctf reader: Avoid duplicating files References: <1859179.TfuLjZUhfy@sali> <87y264mik2.fsf@oracle.com> <1990370.rjD3G2zAS3@sali> <87sfw575dc.fsf@seketeli.org> Date: Wed, 10 Nov 2021 13:06:33 +0100 In-Reply-To: <87sfw575dc.fsf@seketeli.org> (Dodji Seketeli's message of "Tue, 09 Nov 2021 15:47:43 +0100") Message-ID: <87r1bo5i5y.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR10CA0063.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::16) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 Received: from termi.oracle.com (141.143.193.77) by AM0PR10CA0063.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16 via Frontend Transport; Wed, 10 Nov 2021 12:06:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd1b4dd0-2672-402f-cec0-08d9a4428daf X-MS-TrafficTypeDiagnostic: BY5PR10MB4242: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y91JTIVWH6a03i3X/HRCyhO1aJrIjK/mId6H2kdnA3f2WmpLxvKXQ5K/J0vWdXpFWT8DHBpGfTtsXicgl3UPj/YiVBqwrzdlQx4xAM+W03VBsNMqN2qbQAzExCqbRz+P+y8C99FyQTvVlGffjDPteiDynBvFzUYLeBiKOOJ6OnR3lYpzO2Tsvb1dQSDPoEWIaVHpXlKBj5kOzZAwufbVKgN0gNKsmgx29wss/lLGOeOsf4whVraoG0tR6RPs6RRDKTY2xRXz7fwsZTT/xS+Ox/bRepmeFuxHGgFG2rcoYdktcSIR+dIOdMDjBpp7sOXbWz21afbD1Sy9dnS12Xi1lO+InA1QHMUiaUKE3R6Mr3rl1LEUPyChYIyhv/3/IxgcJ3/G6oWjXawROw1LZ/ghTjnLT2qtglCgNLWunZDT8t3k79Ut1SMDT8LYPgHEZrWTsL/iNp+l7nnvunOuhoQALwft9ePO9uydBc1ZvYKmWznJgRr3amWp60JA3PBD4WQJh7BGA98LEJ+sV+lGVIAXcXXMKDXqI/TvIOlBGJjl2tj36KisIpfTd85qRsaLqqpJzmlf8gpuBTKCjYzpp7PoItuN0YX6nWDeI8bMFD6p+sE2pl2AjaW5z/vmdcv1QVVB/btA8a+m2EVG2XMmIZL5lpxSG8aTpKs+7prOR0YqUtKTV2SJ7UBj5rThqT+sfP1SWAaTf8iET4oH3EYbwaAFzw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(107886003)(38100700002)(6666004)(38350700002)(86362001)(956004)(316002)(52116002)(19627235002)(26005)(7696005)(6486002)(2616005)(186003)(5660300002)(4326008)(66556008)(66476007)(36756003)(54906003)(508600001)(66946007)(6916009)(8676002)(53546011)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnY0OWxpQXZYREtUSzczZ1BUL0wyTXVzOUsxSVl0Z3o4QWxJVEE2bnR6dzJE?= =?utf-8?B?UmNvODZwWGF1YVpBNHJFM2t6ZW5yaXVMSDcyOUdOVkM4dlVUL3NXbno4NEJ1?= =?utf-8?B?QlZ6WkZML2h6U1F4RVQrMGZaNmdlWE9mck9DK0F5N1Jld0oyUHh6K2UvR1M0?= =?utf-8?B?djdZRk9qR0VUWVJUU1hCZng3N1dGeFpza3VocUJRWWRXLzdGbzF6eG51L0RV?= =?utf-8?B?YnlqTGswcGFIa2F0bVptT3dnZ0hCMzczNVRVaVBubHVDUmU3NXhzcDErYlND?= =?utf-8?B?NEVVb25VY3YxejlmTVZPaHZzbXV1aGx4MXJFN0YwVk5CVWk2Uytoa08rUklz?= =?utf-8?B?Wm5ZSkkvRWlyTWdINjZHam40bHU0WDdBdWNnY0FscG9vT1R4TkpvMnlJb2tZ?= =?utf-8?B?V3o4RWVVaG5nNXVRT0ZaNjEzUmxWQ3R2Qy95YnNUSzBDQTVJNEdzSklDUlha?= =?utf-8?B?dzBGRGtXZWtaZHE2KzNFang0QWc2c1Y3R2dBcDhFU2RlcGU0cFNXTGpBM0Vx?= =?utf-8?B?MDlkZ0ZydjRhcXhOeGloTzBDcjVuRU5aaUpGQmx0Vmc5blBZcjBkQlBISDBh?= =?utf-8?B?bkhJZ2R4OGgyUDNjZUo1Z2poa0JVNW82VDN0OXdaYU1sWWZIVm9CUjZ4a0pp?= =?utf-8?B?TExobFlEVHF5emM1VE5IOUFQcllpemhZaWFyRkhDREMraHlRZGY4SkkrSzVu?= =?utf-8?B?TmJMb1R5a0IvaWowSXBFclQ3NG1kM0lKMUtwSlZTTjJLNDJDdTIzSERCR3FF?= =?utf-8?B?ZlNhb2JTYXVMWnQ1MUJtMHhWQlpzTXZ6OElxT2xsb3c2dEZmVkxSSUt2Zlho?= =?utf-8?B?U01MNzlNRlIwbHRUZWtIS2NmMmxmUUNEV0toQi9VMDJWazJBcTAvWHA5YXJw?= =?utf-8?B?U05lREd2VlZYK296ZWZGK3I3eHgxVzlWRUdxVkRtUFdFaWJwNDl0WDhWaHB1?= =?utf-8?B?K1JGRk9pVE1HTnZDWmFoQlRPLy9RU3hlMUVsc2JMeFhLOGp3Q3JXUUVNUFNF?= =?utf-8?B?SkFUVUNyelBEL1FUME9ZOGNIdUlLMGx2eGRNVkR3MGtOb3RvNnMreWc4NTBN?= =?utf-8?B?RWRJVkh3M2hXMDd4U2Z1aTIwdG9SSGVtMjJPVkFZY2xGT0tHVVpZbStFYlA3?= =?utf-8?B?RFEwODFhSUw1aVdUQlZDbU9ab1lJSkE4bFgybEQyL3FsYTRLYXB0ekdCbnE4?= =?utf-8?B?cStqWDl4dmt2WWNjNUxXbzdJaHNyam5pOWIxeld4M0d1MGd4cGtwZmFXdUJv?= =?utf-8?B?WkFOT2FVeTNtQVFIbmY4MDNuWFhVY2VJNTIzZlRGd0E3ZXc0QVhVeTFZdkJT?= =?utf-8?B?RVR1RndnNWNoUElZNis0ZDZMTlJjRWw0d1JLTW4vMW5Ka0ZGYjRhSG5RL2ha?= =?utf-8?B?SDFXdG9Sd0JXSmNIbW9kTGxjL3NoTkxHK2VPTnpHV0dBUGFlUzlqOUtGaTY5?= =?utf-8?B?NDUyQVNxdTVRbFYwVmEyS1FrZnk3S09waVIxcEwwSlJ5RnBBdHhBZytBRDRO?= =?utf-8?B?OFlZZjQxNk5WMSt6L0p5aFNsQmlZQWhaNFN3TnhENTAvL3U1N245ODh0bzdw?= =?utf-8?B?dUhXbUtJRFNtUUx0YUQ1aUJjelMvTnFCOW1xWEpxVjZlTmF1K1RDNEVRaXNq?= =?utf-8?B?YVRoUjIvTkcyV3V5M0l6UmNUQWRaTUdLZVNyWWhVWWx3RVhsOVBRNWxsL3p0?= =?utf-8?B?RnhsZmtqYmx5OEg5c3BKckR1NlFhS2ZuMlF0OUo1ZXQvZTduREZDbGZydDlM?= =?utf-8?B?SytJUXU4dTBKWFUwdTlQdG9aamFhdUw5Q0RKandlU2tjaEVDd2IwdWxCWmU5?= =?utf-8?B?Qnc2NTRyWmZYblJBS1lGYzU5S05MQ2czMEw4Rmc1czZrRDd0OVdRa1JGNCs1?= =?utf-8?B?c1lLeCs0SDBZdzBudjh4SnFuSkFTQ3dlYnFvQWxhbHBadmRDR0ExQmlIUzJW?= =?utf-8?B?eGlEeVM4SG1SZnVFMzhvWkUxWUdZeHZkMUlmeWhXR1ljTThXS2hiMlRUNm9y?= =?utf-8?B?SDNqRzRuL2ZuY3ZLbUdhNnZBY0R3M0xpN2F1ME5ZN21IY0xzV0FGbkxTd3ZM?= =?utf-8?B?TTZwY2hwM0h5Vjc5UUNkd3pma2FpNWlHR3FXdGhPSmZ3aWtzZmdnamN5c0VM?= =?utf-8?B?VnBIY1oxd21wMTVEOTNMbnE0eVNpN0dTVmt5SHpBSHZPcSsyTzVKQ09mY0Mv?= =?utf-8?B?VHk1YlJGYzI3bUVORUtsTVFBNUYxMzhDeWF4cUpLUEE3VUMvNDc2aVU1ME1M?= =?utf-8?B?bzgrb1RKT0ZkNDFsVjc5NHR0Ti9RPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd1b4dd0-2672-402f-cec0-08d9a4428daf X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 12:06:40.3790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XYlnzWBworvbfeDPn2CmRqxMKF88YRk/O1a/Ac3XOafS/p7d/8Xf3ixGWSeOJiVU+M+SfJubzIwtYV3gWsGfF1zbAwOtp5jrp1PcgzsoP3Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4242 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10163 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=857 mlxscore=0 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111100064 X-Proofpoint-GUID: U8uM2Abx0WW7378WlUbvefbLCF0x06rD X-Proofpoint-ORIG-GUID: U8uM2Abx0WW7378WlUbvefbLCF0x06rD X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 12:06:56 -0000 > Hello Guillermo and Jose, > > Sorry for my late reply. > > Guillermo Martinez via Libabigail a =C3=A9cri= t: > >> On Thursday, November 4, 2021 2:27:57 AM CST Jose E. Marchesi wrote: >> >> Hello libabigail team, >>>=20 >>> > I'm working in the implementation of regression tests for ctf reader >>> > (tests/test-read-ctf.cc), it's very similar to test-read-dwarf.cc, so >>> > they have some C and header source files that are common among >>> > them, e.g: >>> > >>> > tests/data/test-read-ctf/PR27700/include-dir/priv.h >>> > tests/data/test-read-ctf/PR27700/include-dir/pub.h >>> > tests/data/test-read-ctf/PR27700/pub-incdir/inc.h >>> > tests/data/test-read-ctf/PR27700/test-PR27700.c >>> > tests/data/test-read-ctf/test-PR26568-1.c >>> > tests/data/test-read-ctf/test-PR26568-2.c >>> > >>> > So, we're planning move those common source file to: >>> > >>> > tests/data/test-read-common/ > > Great. > >>> > But we still need *two different* binary files with the debugging >>> > information: DWARF (-gdwarf) and CTF (-gctf), that they would=20 >>> > need to be recompiled. The current implementation to test ctf reader >>> > use binary files previously compiled, so there is one file for=20 >>> > each binary format: >>> > =20 >>> > tests/data/test-read-*ctf*/test-PR26568-1.o >>> > ... >>> > tests/data/test-read-*dwarf*/test-PR26568-1.o >>> > >>> > So, Are you agree with this approach? >>> > >>> > We are looking for the way to avoid duplicating files :-) >>> > >>> > Thanks in advanced for your comments! > > On Thursday, November 4, 2021 2:27:57 AM CST Jose E. Marchesi wrote: > > >>> An alternative to have two copies of compiled objects is to have just >>> one copy (in test-read-common) compiled with both -gdwarf -gctf. > > Right, we could do that too. You'll thus need to adjust the existing > tests in test-read-dwarf.cc to make them pick their data from > test-read-common instead, e.g: > > This: > > { > "data/test-read-dwarf/test0", > "", > "", > SEQUENCE_TYPE_ID_STYLE, > "data/test-read-dwarf/test0.abi", > "output/test-read-dwarf/test0.abi" > }, > > would be changed into: > > { > "data/test-read-common/test0", > "", > "", > SEQUENCE_TYPE_ID_STYLE, > "data/test-read-common/test0.abi", > "output/test-read-common/test0.abi" > }, > > > The tests/data/Makefile.am will also need some adjustments. > > I think that sounds a fair path to take, as far as I am concerned. I agree. The binaries are big enough already :)