From: Dodji Seketeli <dodji@redhat.com>
To: Dodji Seketeli <dodji@redhat.com>
Cc: libabigail@sourceware.org, woodard@redhat.com
Subject: [PATCH 6/6] abipkgdiff: make --self-check to fail on any change against own ABIXML
Date: Fri, 27 Nov 2020 18:08:43 +0100 [thread overview]
Message-ID: <87r1oe682s.fsf@redhat.com> (raw)
In-Reply-To: <87h7pa7n8c.fsf@redhat.com> (Dodji Seketeli's message of "Fri, 27 Nov 2020 17:56:03 +0100")
Hello,
Now that several subtle causes of spurious ABI change report when
comparing a binary against its own ABIXML have been addressed, this
patch makes 'abipkgdiff --self-check' to fail on any ABI change
reported. That is, harmless changes are not ignored anymore.
* tools/abipkgdiff.cc (compare_to_self): Report *any* ABI change.
Not just the "net" changes.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
tools/abipkgdiff.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc
index 2968338a..709b687a 100644
--- a/tools/abipkgdiff.cc
+++ b/tools/abipkgdiff.cc
@@ -1649,7 +1649,7 @@ compare_to_self(const elf_file& elf,
<< "... Comparing the ABIs: DONE\n";
abidiff_status s = abigail::tools_utils::ABIDIFF_OK;
- if (diff->has_net_changes())
+ if (diff->has_changes())
s |= abigail::tools_utils::ABIDIFF_ABI_CHANGE;
if (diff->has_incompatible_changes())
s |= abigail::tools_utils::ABIDIFF_ABI_INCOMPATIBLE_CHANGE;
--
2.29.2
--
Dodji
prev parent reply other threads:[~2020-11-27 17:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 16:56 [PATCH 0/6] Fix subtle ABI artifact representation issues Dodji Seketeli
2020-11-27 17:03 ` [PATCH 1/6] writer: Emit definitions of declarations when they are present Dodji Seketeli
2020-11-30 13:49 ` Giuliano Procida
2020-11-30 15:56 ` Dodji Seketeli
2020-11-30 18:15 ` Giuliano Procida
2020-12-01 9:51 ` Dodji Seketeli
2020-11-27 17:05 ` [PATCH 2/6] ir: Introduce internal pretty representation for anonymous classes Dodji Seketeli
2020-11-27 17:06 ` [PATCH 3/6] reader: Don't lose anonymous-ness of decl-only classes Dodji Seketeli
2020-11-27 17:07 ` [PATCH 4/6] dwarf-reader: Avoid having several functions with the same symbol Dodji Seketeli
2020-11-27 17:08 ` [PATCH 5/6] abidw: make --abidiff report any change against own ABIXML Dodji Seketeli
2020-11-27 17:08 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1oe682s.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
--cc=woodard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).