From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by sourceware.org (Postfix) with ESMTPS id 23F5A3858D35 for ; Mon, 6 Jul 2020 11:23:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23F5A3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id EFFA460002; Mon, 6 Jul 2020 11:23:42 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id CBD591800867; Mon, 6 Jul 2020 13:23:41 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 09/11] Support constructing opaque types for enums Organization: Me, myself and I References: <20200610115940.26035-1-gprocida@google.com> <20200610115940.26035-10-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.seketeli.net/~dodji Date: Mon, 06 Jul 2020 13:23:41 +0200 In-Reply-To: <20200610115940.26035-10-gprocida@google.com> (Giuliano Procida's message of "Wed, 10 Jun 2020 12:59:38 +0100") Message-ID: <87r1tosx8i.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2020 11:23:45 -0000 Giuliano Procida a =C3=A9crit: > From: Dodji Seketeli > > Now that we are to support opaque types for enums, we ought to support > building opaque types for enums as well, to mimic the opaque type > design pattern used in C, when private types are specified with type > suppression specifications. > > The core of this change is to make get_opaque_version_of_type work for > enums as well, just like what it does for classes. Note that that > function doesn't support opaque unions yet either. That should be > added at a later point in time, I guess. > > * src/abg-dwarf-reader.cc > (build_internal_underlying_enum_type_name) > (build_enum_underlying_type): Factorize these functions out of ... > (build_enum_type): ... here. > (get_opaque_version_of_type): Make this handle enums as well. So > make its return type be type_or_decl_base_sptr, rather than just > class_or_union_sptr as it used to be. This patch is now fused with the previous one in the series so I am dropping it. Cheers, --=20 Dodji