From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by sourceware.org (Postfix) with ESMTPS id 6EDBF385C6E5; Fri, 7 Jul 2023 08:38:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EDBF385C6E5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org X-GND-Sasl: dodji@seketeli.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1688719138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4P4uLxxDUNwnXF91aY6G/oDh4sm5j+i7+kZwrjDmPL0=; b=RcSxpoO456Oe+EpKsdxOSXsLgmbqqm4mat4zA38ItK3hWc418RsDrzC3kfQkViIgCif38s B36U6LsMylRtCgFOc/aQagBudfsXXib0NX0bq8vhrNrGMSnHRPUBPRezRhap+v4McV/yeu EO8Iz+GTIvezbYDADACkJootFFQCnPrDQz6nuVg0Pv1JlZDmAUBfwi080GnSRR1Zb2E08m FE1vuZRms7oRq5n20/Y5hYkVMNilepFPHdcPVvY6MKyVNnjj4vIo/m9gjfSdq7pSTOvMhb ipdmJGsFb7ANmruIGgHUspjPNOAZ/PTbfYQ0mLND6pMhWxLSCELm7iojYRhpfA== X-GND-Sasl: dodji@seketeli.org Received: by mail.gandi.net (Postfix) with ESMTPSA id 11737C0006; Fri, 7 Jul 2023 08:38:57 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 36367B4FFD; Fri, 7 Jul 2023 10:38:57 +0200 (CEST) From: Dodji Seketeli To: "david.marchand at redhat dot com via Libabigail" Cc: "david.marchand at redhat dot com" Subject: Re: [Bug default/30034] [libabigail] Handle library splitting Organization: Me, myself and I References: X-Operating-System: CentOS Stream release 9 X-URL: http://www.seketeli.net/~dodji Date: Fri, 07 Jul 2023 10:38:57 +0200 In-Reply-To: (david marchand at redhat dot com via Libabigail's message of "Thu, 06 Jul 2023 13:38:47 +0000") Message-ID: <87sfa015ge.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: "david.marchand at redhat dot com via Libabigail" a =C3=A9crit: [...] > --- Comment #23 from David Marchand --- > For the record, before I go off for some weeks. [...] > - You may want to fix typos (invalid -to suffix in the options) in the RE= ADME > file: Fixed. > - The mandatory aspect of the --add-binaries-toX options is disturbing, b= ut it > seems to work if I pass an empty list --add-binaries-to1=3D Fixed. The --add-binaries1=3D is no longer necessary if you have specified a --add-binaries2=3D, for instance. > - Requiring a '=3D' for those --add-binariesX options is surprising as ot= her > options won't accept a =3D. Fixed. The '=3D' is no longer necessary. > - Now performance / runtime wise, before the DPDK split: > * before the DPDK split, with 2.2 libabigail package from fc37: > real 0m2,233s > user 0m20,185s > sys 0m2,354s > * before the DPDK split, with libabigail binaries generated against this = branch > and no change in abidiff runtime: > real 0m2,414s > user 0m21,802s > sys 0m3,502s > > And with the DPDK split: > * using --follow-dependencies + --add-binaries-dirX: > real 0m20,935s > user 3m4,397s > sys 1m45,828s > * using --add-binaries1=3D --add-binaries2=3Dlibrte_log.so + --add-binari= es-dirX: > real 0m2,703s > user 0m24,006s > sys 0m4,458s > > Which seems acceptable to me :-). Good to hear. I have updated the branch with the fixes. Thank you for testing and providing this timely and valuable feedback. --=20 Dodji