From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by sourceware.org (Postfix) with ESMTPS id 23AC63858C50 for ; Mon, 27 Feb 2023 18:54:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23AC63858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id CD27B24000A; Mon, 27 Feb 2023 18:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1677524063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iqOiExFOSF7DFj/ZgA3BeABid2A6iPVWACFWH01DlNg=; b=S11yvxeVcKBp+a94jnb0b97MWc2tsajv2cZUgWIbs/XmN5wBOU+Msdtp0hkse4I8KYhhj2 xbHWy7YLEm0XD4QIhoeudbyVgzLpM0xstCjlLEicVTsL+GWvo9zAUGYSjtSRY9Le0Tj/MP yvXQtmLMdRWYsljMag+5EKweQTQ37eqQ/xkwwQp2dJtCCLUfOebKyyt/g9RKM+GqwGTFK3 OhsWkpuhzO9hcRy3aqJA0HKDQ7XSlC45mgVExuJqq735c4N/xsU5PpPJulOdvL94PttIkp 1y+iTRLXdcxheM4CHSiQIvbeMnZ0X6i+lnKx/Wpe3ewkEiT+y0Y1/ixEfLwr+A== Received: by localhost (Postfix, from userid 1000) id 0F6B4581C79; Mon, 27 Feb 2023 19:54:20 +0100 (CET) From: Dodji Seketeli To: "Guillermo E. Martinez via Libabigail" Cc: "Guillermo E. Martinez" Subject: Re: [PATCH] abipkgdiff: Fix comparing CTF kABIs using Oracle Linux RPMs Organization: Me, myself and I References: <20230217005743.2607886-1-guillermo.e.martinez@oracle.com> X-Operating-System: Fedora 38 X-URL: http://www.seketeli.net/~dodji Date: Mon, 27 Feb 2023 19:54:20 +0100 In-Reply-To: <20230217005743.2607886-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Thu, 16 Feb 2023 18:57:43 -0600") Message-ID: <87sferrlb7.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Guillermo, "Guillermo E. Martinez via Libabigail" a =C3=A9crit: > Hello, > > This patch is meant to fix how `abipkgdiff' using CTF origin is looking > for dependencies to analyze kABIs. IMHO `file_is_kernel_package' > function is relying on package name, so when `--ctf' is provided, it only > will work with executables under uncompressed directories and it never > will try to find `vmlinux.cfa' because it is just needed by KABIs. I > think that an option to force handle a packages as kernel would be nice > regardless the package name. > > Please let me know your comments, > Thanks in advanced!, Ahh, okay, I see. Actually, I think the initial way in which file_is_kernel_package detects that a package is a kernel package is sub-optimal. Rather than looking at the name of the package, I think it should instead look for the 'vmlinuz' binary file inside the package. I will soon post a patch that amends yours by fixing that initial issue and adds the vmlinux.ctfa related fix to it. [...] Thanks for looking into this. Cheers, --=20 Dodji