[PATCH 0/3] Make integral types of same base and size compatible

[Dodji Seketeli <dodji@redhat.com>]

Hello,

On some platforms, 'long int' and 'long long int' have the same size.
On those platforms, those two types should be considered ABI
compatible.  Today, libabigail always consider these types as
different.  This leads some spurious type changes, especially when,
e.g, a type struct Foo is defined in two different translation unit,
once using a "long long int" through a typedef, and once using a "long
int" through a typedef.  In that case, libabigail (wrongly) considers
the two struct Foo as different.  And that leads to weird and hard to
debug self comparison failures down the road.  For instance, the
following command fails:

    $ time tools/fedabipkgdiff --debug --self-compare -a --from fc36 btrfs-progs

Fixing this issue uncovers two other issues that needed fixing
altogether.

First, in some cases, the sorting of array types can be non-stable in
the abixml output.  This is due to some ambiguities that can happen
with the representation of array element types.  The first patch of
the series address that.

Second, some qualified types can be sometimes represented with
redundant (and thus very confusing) CV-qualifiers.  The second patch
removes those and provides a hopefully less confusing pretty
representation of qualified types.

Below is the summary of the patch series that was applied to master.

Dodji Seketeli (3):
  ir: Disambiguate sorting of array element types
  dwarf-reader: Remove redundant qualifiers from qualified types
  ir: Consider integral types of same kind and size as equivalent

 include/abg-fwd.h                             |     9 +
 include/abg-ir.h                              |    10 +
 src/abg-dwarf-reader.cc                       |     5 +-
 src/abg-ir-priv.h                             |    11 +-
 src/abg-ir.cc                                 |   419 +-
 src/abg-reader.cc                             |     3 +-
 .../qualifier-typedef-array-report-1.txt      |    40 +-
 tests/data/test-annotate/libtest23.so.abi     |   748 +-
 .../test-annotate/libtest24-drop-fns-2.so.abi |   794 +-
 .../test-annotate/libtest24-drop-fns.so.abi   |   794 +-
 tests/data/test-annotate/test0.abi            |    48 +-
 .../data/test-annotate/test14-pr18893.so.abi  |  2472 +-
 .../data/test-annotate/test15-pr18892.so.abi  | 12362 +++--
 .../data/test-annotate/test17-pr19027.so.abi  |  2246 +-
 ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 11742 +++--
 ...19-pr19023-libtcmalloc_and_profiler.so.abi | 16188 +++---
 ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 16864 +++---
 .../data/test-annotate/test21-pr19092.so.abi  |   680 +-
 .../PR25058-liblttng-ctl-report-1.txt         |     4 +-
 .../test-PR26739-2-report-0.txt               |    10 +-
 .../PR22015-libboost_iostreams.so.abi         |  3520 +-
 .../test-read-dwarf/PR22122-libftdc.so.abi    |  3929 +-
 .../data/test-read-dwarf/PR25007-sdhci.ko.abi |  9147 ++--
 .../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi |   169 +-
 tests/data/test-read-dwarf/libtest23.so.abi   |   708 +-
 .../libtest24-drop-fns-2.so.abi               |   760 +-
 .../test-read-dwarf/libtest24-drop-fns.so.abi |   760 +-
 .../test-read-dwarf/test-libaaudio.so.abi     |   348 +-
 .../test-read-dwarf/test-libandroid.so.abi    |  1296 +-
 tests/data/test-read-dwarf/test0.abi          |    47 +-
 tests/data/test-read-dwarf/test0.hash.abi     |    13 +-
 tests/data/test-read-dwarf/test1.hash.abi     |     4 +-
 .../test-read-dwarf/test10-pr18818-gcc.so.abi |  7328 ++-
 .../test-read-dwarf/test11-pr18828.so.abi     | 14955 +++---
 .../test-read-dwarf/test12-pr18844.so.abi     | 25236 +++++----
 .../test-read-dwarf/test14-pr18893.so.abi     |  1580 +-
 .../test-read-dwarf/test15-pr18892.so.abi     | 11647 +++--
 .../test-read-dwarf/test16-pr18904.so.abi     | 16732 +++---
 .../test-read-dwarf/test17-pr19027.so.abi     |  2056 +-
 ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 11520 +++--
 ...19-pr19023-libtcmalloc_and_profiler.so.abi | 15834 +++---
 ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 16406 +++---
 .../test-read-dwarf/test21-pr19092.so.abi     |   656 +-
 .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 42542 ++++++++--------
 .../test9-pr18818-clang.so.abi                |  5412 +-
 tests/data/test-read-write/test22.xml         |     7 +-
 tests/data/test-read-write/test23.xml         |     7 +-
 .../test28-without-std-fns-ref.xml            |   648 +-
 .../test28-without-std-vars-ref.xml           |   590 +-
 49 files changed, 129753 insertions(+), 129553 deletions(-)

-- 
2.36.1

Cheers,

-- 
		Dodji