From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by sourceware.org (Postfix) with ESMTPS id 799163858D37 for ; Wed, 19 Jan 2022 10:12:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 799163858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 8EC1740008; Wed, 19 Jan 2022 10:12:49 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id A7550581C2E; Wed, 19 Jan 2022 11:12:42 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 4/5] XML writer: map type ids by bare pointer Organization: Me, myself and I References: <20211203114622.2944173-1-maennich@google.com> <20211203114622.2944173-5-maennich@google.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Wed, 19 Jan 2022 11:12:42 +0100 In-Reply-To: <20211203114622.2944173-5-maennich@google.com> (Matthias Maennich's message of "Fri, 3 Dec 2021 11:46:22 +0000") Message-ID: <87sftkavad.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2022 10:12:53 -0000 Matthias Maennich a =C3=A9crit: > This is a performance and safety improvement made possible by previous > changes which ensure that the same pointers are used for insertion and > look-up. > > This change affects two test cases. In more detail: > > The test case test-read-dwarf/PR22122-libftdc.so.abi has many > duplicate type-id-60 which appear to all be types defined with a DWARF > DW_AT_signature attribute. These are made into separate types by this > change, but remain incomplete. > > The test case test-read-dwarf/PR25007-sdhci.ko.abi has duplicate > declarations and these get split into duplicate declarations with new > type ids following this change. The test suite runs with an implicit > --no-linux-kernel-mode so the duplicates are treated separately. They > presumably had the same type ids before this change due to deep > equality considering them equal. > > * src/abg-writer.cc (type_ptr_map): use default equality on > type_base pointer. > * tests/data/test-read-dwarf/PR22122-libftdc.so.abi: Refresh > test case, as described above. > * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Likewise. > > Reviewed-by: Giuliano Procida > Signed-off-by: Matthias Maennich Applied to master, thanks! [...] Cheers, --=20 Dodji