From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net
 [217.70.183.199])
 by sourceware.org (Postfix) with ESMTPS id 46A92386F00E
 for <libabigail@sourceware.org>; Wed, 10 Mar 2021 18:00:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 46A92386F00E
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=dodji@seketeli.org
X-Originating-IP: 88.120.130.27
Received: from localhost (unknown [88.120.130.27])
 (Authenticated sender: dodji@seketeli.org)
 by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 1906AFF808;
 Wed, 10 Mar 2021 18:00:24 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 3DA13580100; Wed, 10 Mar 2021 19:00:23 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org,  gprocida@google.com,  kernel-team@android.com
Subject: Re: [PATCH 04/20] dwarf-reader split: create
 abg-symtab-reader.{h,cc} and test case
Organization: Me, myself and I
References: <20200619214305.562-1-maennich@google.com>
 <20210127125853.886677-1-maennich@google.com>
 <20210127125853.886677-5-maennich@google.com>
X-Operating-System: Fedora 34
X-URL: http://www.seketeli.net/~dodji
Date: Wed, 10 Mar 2021 19:00:23 +0100
In-Reply-To: <20210127125853.886677-5-maennich@google.com> (Matthias
 Maennich's message of "Wed, 27 Jan 2021 12:58:37 +0000")
Message-ID: <87sg52zy6g.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Mar 2021 18:00:29 -0000

Matthias Maennich <maennich@google.com> a =C3=A9crit:

> abg-symtab-reader.{h,cc} shall contain the refactored symtab reader.
> Create the stub files, an empty unit test and hook everything up in the
> make system.
>
>     * src/abg-symtab-reader.h: New header file.
>     * src/abg-symtab-reader.cc: New source file.
>     * src/Makefile.am: Add new source files.
>     * tests/Makefile.am: Add new test case runtestsymtabreader.
>     * tests/test-symtab-reader.cc: New test source file.
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>

Applied to master, thanks!

[...]

Cheers,

--=20
		Dodji