From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by sourceware.org (Postfix) with ESMTPS id 136C3383E838 for ; Mon, 4 May 2020 13:36:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 136C3383E838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7007C200009; Mon, 4 May 2020 13:36:47 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id A1B34581891; Mon, 4 May 2020 15:36:46 +0200 (CEST) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, kernel-team@android.com, Mark Wielaard Subject: Re: [PATCH 1/2] test-types-stability: parallelize test case alternatives Organization: Me, myself and I References: <20200429152812.217166-1-maennich@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Mon, 04 May 2020 15:36:46 +0200 In-Reply-To: <20200429152812.217166-1-maennich@google.com> (Matthias Maennich's message of "Wed, 29 Apr 2020 17:28:12 +0200") Message-ID: <87sggf95zl.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2020 13:37:00 -0000 Hello Matthias, Matthias Maennich a =C3=A9crit: > Commit a9f5fb408946 ("Add --no-write-default-sizes option.") introduced > a new test variant for test-types-stability that is actually independent > of the original test case in terms of execution. Hence it can be > expressed as a separate test case. So, do that by parametrizing the > test_task struct with a new no_default_sizes flag and schedule a > separate test case in the main loop. > > That test runs now ~twice as fast dropping from roughly 20s on my > machine to 10s. That effectively removes it from the critical path of > make check, which is now back to about 15s on my machine with my > configuration. > > * tests/test-types-stability.cc (test_task): add field no_default_sizes > (test_task::perform) Switch on the new flag to test a different > behaviour. > (main): Schedule an additional test case to test with the new > flag. Applied to master, thanks! Cheers, --=20 Dodji