From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40360 invoked by alias); 21 Jan 2020 16:24:40 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 40239 invoked by uid 89); 21 Jan 2020 16:24:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: relay5-d.mail.gandi.net Received: from relay5-d.mail.gandi.net (HELO relay5-d.mail.gandi.net) (217.70.183.197) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Jan 2020 16:24:15 +0000 X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E4C7B1C000B; Tue, 21 Jan 2020 16:24:12 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 7A0191800946; Tue, 21 Jan 2020 17:24:11 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 2/2] KMI Whitelists: Drop old whitelist extraction methods Organization: Me, myself and I References: <20200114173450.137714-1-maennich@google.com> <20200114173450.137714-2-maennich@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.seketeli.net/~dodji Date: Wed, 01 Jan 2020 00:00:00 -0000 In-Reply-To: <20200114173450.137714-2-maennich@google.com> (Matthias Maennich's message of "Tue, 14 Jan 2020 17:34:50 +0000") Message-ID: <87sgk8u6ac.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-q1/txt/msg00035.txt Matthias Maennich a =C3=A9crit: > The previous commit introduces a new (tested) way of creating function > and variable suppressions from multiple whitelist definitions. Migrate > to this new way of processing KMI whitelists. > > * include/abg-tools-utils.h > (gen_suppr_spec_from_kernel_abi_whitelist): Delete declaration. > * src/abg-tools-utils.cc > (gen_suppr_spec_from_kernel_abi_whitelist): Delete definition > and migrate users to gen_suppr_spec_from_kernel_abi_whitelists. > * tools/abidiff.cc (set_suppressions): Migrate from using > gen_suppr_spec_from_kernel_abi_whitelist to > gen_suppr_spec_from_kernel_abi_whitelists. > * tools/abidw.cc (set_suppressions): Likewise. > * tools/abipkgdiff.cc: Drop unused using definition. > * tools/kmidiff.cc: Likewise. This is OK to commit to master once the first patch of the series is in. Thank you for working on this! Cheers, --=20 Dodji