* [PATCH, applied] ir: remove redundant cycle detection code in equals
@ 2022-10-10 11:57 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2022-10-10 11:57 UTC (permalink / raw)
To: libabigail
Hello,
While looking at something else, I realized that in the overload for
the equals() function for class_or_union, the cycle detection
management code was redundant for the case where we are looking
comparing a decl-only class to another class.
This patch removes that redundant code.
* src/abg-ir.cc (equals): In the overload for class_or_union
remove redundant cycle detection code when comparison a decl-only
class to another class.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
src/abg-ir.cc | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 2cb74339..e6b8409a 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -22240,10 +22240,6 @@ equals(const class_or_union& l, const class_or_union& r, change_kind* k)
}
}
- RETURN_TRUE_IF_COMPARISON_CYCLE_DETECTED(l, r);
-
- mark_types_as_being_compared(l, r);
-
bool val = *def1 == *def2;
if (!val)
if (k)
--
2.38.0.rc2
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-10 11:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 11:57 [PATCH, applied] ir: remove redundant cycle detection code in equals Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).