From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 20E843858D37 for ; Mon, 10 Oct 2022 11:57:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20E843858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665403062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=bduuQxAXN2YBIhcaYho+ngKaaC5wWF5QcOeWXcqhu0A=; b=dOIipjp7Wc1knON4AUw6WXes7PyST2dQ70OLusdZDSmY2u4LP/H0fBrFnBnNeMjZAo/IiP V3Ax2x/W6UJ+aP3HIPZq++trYnUA6LW3DlrreaQD5V3XH4bZIDJE1JnrN3d2qBdyCrJ6ht qHy35wzSITmQTMopcwt+MTJQNuQGdzo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-608-I2YjK2CzPSiPQnvBpTdReA-1; Mon, 10 Oct 2022 07:57:41 -0400 X-MC-Unique: I2YjK2CzPSiPQnvBpTdReA-1 Received: by mail-wm1-f72.google.com with SMTP id v191-20020a1cacc8000000b003bdf7b78dccso6900824wme.3 for ; Mon, 10 Oct 2022 04:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bduuQxAXN2YBIhcaYho+ngKaaC5wWF5QcOeWXcqhu0A=; b=dYMbAHg1TF4ltsIIKvwftarsUsiLhDxjqEQRfP8CTbdbEqoZSOAa/Kk0eynrh+waZ2 w56i65ZyAbpWYLjVXzPzHf+TI7lWy7ufiuyBIIugtAqZs0+KmNNPTsjwPNgeYlC3wP94 arySTZh4/PKcRNDVBaroLyB9Suq9XvqahTwpRLQM26wmWIzb45dQM3Wn2fXAueApB+9Q tuX0hxVkz8zkJ7IhsxypT00bdNaWsspKZdLwDGmhT1qulnqhrZl35vip0Ge/5P3BDDGH 4JzTKm6LhbL0tfOZTasQ22DjDug4CJp2fbfaHYI/2UdJgNh3gNGRFad8YYWIbp1OWwTx Iz9A== X-Gm-Message-State: ACrzQf2t5e2vMwTxMC6AzqFEahx1cvY1tmTFRtAdUJE+qBx7NFIqRmB4 Qs/IYYolkUduRYMepib2m6q1Bd/Pw6VjSVEAJzsDIy0nSB3OhPaMSlpY+kU28ba9ke9IbaOf3tJ Hqh0VhXQeej0uLUbzRdKF/mEcDWvUykQwPJ8bBwsFr8jCASm1Mx855vrSkB6N8g7ji85x X-Received: by 2002:a05:600c:88a:b0:3c5:c9e3:15cc with SMTP id l10-20020a05600c088a00b003c5c9e315ccmr5162533wmp.67.1665403060476; Mon, 10 Oct 2022 04:57:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5khvMJivuw5UHJJUSn3O/zvD6uWxZTRntU4O48R/i9cyKWzBLkWOmuCy3JanhL21fL9MJgYQ== X-Received: by 2002:a05:600c:88a:b0:3c5:c9e3:15cc with SMTP id l10-20020a05600c088a00b003c5c9e315ccmr5162512wmp.67.1665403060215; Mon, 10 Oct 2022 04:57:40 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id u16-20020adfdd50000000b002238ea5750csm11092997wrm.72.2022.10.10.04.57.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 04:57:39 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 1A206581C53; Mon, 10 Oct 2022 13:57:38 +0200 (CEST) From: Dodji Seketeli To: libabigail@sourceware.org Subject: [PATCH, applied] ir: remove redundant cycle detection code in equals Organization: Red Hat / France X-Operating-System: Fedora 38 X-URL: http://www.redhat.com Date: Mon, 10 Oct 2022 13:57:38 +0200 Message-ID: <87tu4b28nh.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, While looking at something else, I realized that in the overload for the equals() function for class_or_union, the cycle detection management code was redundant for the case where we are looking comparing a decl-only class to another class. This patch removes that redundant code. * src/abg-ir.cc (equals): In the overload for class_or_union remove redundant cycle detection code when comparison a decl-only class to another class. Signed-off-by: Dodji Seketeli --- src/abg-ir.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/abg-ir.cc b/src/abg-ir.cc index 2cb74339..e6b8409a 100644 --- a/src/abg-ir.cc +++ b/src/abg-ir.cc @@ -22240,10 +22240,6 @@ equals(const class_or_union& l, const class_or_union& r, change_kind* k) } } - RETURN_TRUE_IF_COMPARISON_CYCLE_DETECTED(l, r); - - mark_types_as_being_compared(l, r); - bool val = *def1 == *def2; if (!val) if (k) -- 2.38.0.rc2 -- Dodji