From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Cc: woodard@redhat.com
Subject: [PATCH, applied] ir: Support cloning data members of unions
Date: Thu, 22 Sep 2022 16:51:04 +0200 [thread overview]
Message-ID: <87tu4z4g4n.fsf@redhat.com> (raw)
Hello,
When cloning a data member, var_decl::clone wrongly assumes we are
looking at a data member of a class. It could also be a data member
of an union. Fixed thus.
This fixes crashes when self comparing Fedora 36 packages of the qt6
group with the command:
$ fedabipkgdiff --self-compare --from fc36 qt6-qtsensors
There are lot of other packages from the qt group that were making
this command fail, but I am not mentioning them here for the sake
conciseness.
* src/abg-ir.cc (var_decl::clone): Support cloning data members
for unions.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
src/abg-ir.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 1cd2a219..f739b126 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -19131,7 +19131,7 @@ var_decl::clone() const
if (is_member_decl(*this))
{
- class_decl* scope = dynamic_cast<class_decl*>(get_scope());
+ class_or_union* scope = is_class_or_union_type(get_scope());
scope->add_data_member(v, get_member_access_specifier(*this),
get_data_member_is_laid_out(*this),
get_member_is_static(*this),
--
2.37.2
--
Dodji
reply other threads:[~2022-09-22 14:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu4z4g4n.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
--cc=woodard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).