public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org,  kernel-team@android.com,
	 maennich@google.com
Subject: Re: [PATCH v5 3/4] Linux symbol CRCs: support 0 and report presence changes
Date: Thu, 30 Jun 2022 18:41:04 +0200	[thread overview]
Message-ID: <87tu82cden.fsf@seketeli.org> (raw)
In-Reply-To: <20220613142533.3676501-4-gprocida@google.com> (Giuliano Procida's message of "Mon, 13 Jun 2022 15:25:32 +0100")

Hello,

Giuliano Procida <gprocida@google.com> a écrit:

> The CRC with value zero was used to mean "absent". This can be better
> modelled using optional.
>
> This commit makes this change and also tweaks reporting so that
> disappearing / appearing CRCs are noted. This should be essentially
> impossible unless CRCs are enabled / disabled altogether but would be
> very noteworthy otherwise.
>
> 	* include/abg-ir.h (elf_symbol::elf_symbol): Argument crc is
> 	now an optional defaulted to absent.
> 	(elf_symbol::create): Likewise.
> 	(elf_symbol::get_crc): Now returns an optional uint64_t.
> 	(elf_symbol::set_src): Now takes an optional uint64_t.
> 	* src/abg-comp-filter.cc (crc_changed): Simplify comparison.
> 	* src/abg-ir.cc (elf_symbol::priv): Member crc_ is now an
> 	optional uint64_t.
> 	(elf_symbol::priv::priv): Argument crc is now an optional
> 	uint64_t.
> 	(elf_symbol::elf_symbol): Likewise.
> 	(elf_symbol::create): Argument crc is now an optional uint64_t
> 	and defaults to absent.
> 	(textually_equals): Simplify comparison.
> 	(elf_symbol::get_crc): Now returns an optional uint64_t.
> 	(elf_symbol::set_crc): Now takes an optional uint64_t.
> 	* src/abg-reader.cc (build_elf_symbol): Treat CRC 0 the same
> 	as other CRC values.
> 	* src/abg-reporter-priv.cc (maybe_report_diff_for_symbol):
> 	Treat CRC 0 the same as other CRC values and also report
> 	changes to CRC presence.
> 	* src/abg-writer.cc (write_elf_symbol): Treat CRC 0 the same
> 	as other CRC values.
> 	* tests/data/Makefile: Remove test-abidiff/test-crc-report.txt
> 	and add test-abidiff/test-crc-report-{0-1,1-0,1-2}.txt.
> 	* tests/data/test-abidiff/test-crc-report-0-1.txt: Report
> 	showing additional of CRCs.
> 	* tests/data/test-abidiff/test-crc-report-1-0.txt: Report
> 	showing removal of CRCs.
> 	* tests/data/test-abidiff/test-crc-report-1-2.txt: Renamed
> 	from tests/data/test-abidiff/test-crc-report.txt.
> 	* tests/test-abidiff.cc: Update test cases that no longer
> 	generate empty reports.
> 	* tests/test-symtab.cc: Update KernelSymtabsWithCRC test.
>
> Reviewed-by: Matthias Maennich <maennich@google.com>
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to master, thanks !

[...]

Cheers,

-- 
		Dodji

  reply	other threads:[~2022-06-30 16:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 18:13 [PATCH 0/2] Bug 28954 - add Linux Kernel symbol namespace support Giuliano Procida
2022-03-14 18:13 ` [PATCH 1/2] optional: add operator== and operator!= Giuliano Procida
2022-03-15 11:02   ` Matthias Maennich
2022-03-16  9:31     ` Giuliano Procida
2022-03-14 18:13 ` [PATCH 2/2] add Linux kernel symbol namespace support Giuliano Procida
2022-03-15 11:25   ` Matthias Maennich
2022-03-16 16:30 ` [PATCH v2 0/4] add symbol namespace support, update symbol CRC support Giuliano Procida
2022-03-16 16:30   ` [PATCH v2 1/4] optional: minor improvements Giuliano Procida
2022-03-17 10:56     ` Matthias Maennich
2022-03-16 16:30   ` [PATCH v2 2/4] crc_changed: eliminate copying of shared_ptr values Giuliano Procida
2022-03-17 11:01     ` Matthias Maennich
2022-03-16 16:30   ` [PATCH v2 3/4] add Linux kernel symbol namespace support Giuliano Procida
2022-03-17 11:57     ` Matthias Maennich
2022-03-16 16:30   ` [PATCH v2 4/4] Linux symbol CRCs: support 0 and report presence changes Giuliano Procida
2022-03-17 12:01     ` Matthias Maennich
2022-03-17 16:38   ` [PATCH v3 0/4] add symbol namespace support, update symbol CRC support Giuliano Procida
2022-03-17 16:38     ` [PATCH v3 1/4] crc_changed: eliminate copying of shared_ptr values Giuliano Procida
2022-03-17 16:38     ` [PATCH v3 2/4] optional: minor improvements Giuliano Procida
2022-03-17 16:38     ` [PATCH v3 3/4] Linux symbol CRCs: support 0 and report presence changes Giuliano Procida
2022-03-17 16:38     ` [PATCH v3 4/4] add Linux kernel symbol namespace support Giuliano Procida
2022-03-21 12:53       ` Matthias Maennich
2022-03-21 15:52         ` Giuliano Procida
2022-03-21 16:02     ` [PATCH v4 0/4] add symbol namespace support, update symbol CRC support Giuliano Procida
2022-03-21 16:02       ` [PATCH v4 1/4] crc_changed: eliminate copying of shared_ptr values Giuliano Procida
2022-03-21 16:02       ` [PATCH v4 2/4] optional: minor improvements Giuliano Procida
2022-03-21 16:02       ` [PATCH v4 3/4] Linux symbol CRCs: support 0 and report presence changes Giuliano Procida
2022-03-21 16:02       ` [PATCH v4 4/4] add Linux kernel symbol namespace support Giuliano Procida
2022-06-13 14:25       ` [PATCH v5 0/4] add symbol namespace support, update symbol CRC support Giuliano Procida
2022-06-30 16:39         ` Dodji Seketeli
2022-06-13 14:25       ` [PATCH v5 1/4] crc_changed: eliminate copying of shared_ptr values Giuliano Procida
2022-06-30 16:40         ` Dodji Seketeli
2022-06-13 14:25       ` [PATCH v5 2/4] optional: minor improvements Giuliano Procida
2022-06-30 16:40         ` Dodji Seketeli
2022-06-13 14:25       ` [PATCH v5 3/4] Linux symbol CRCs: support 0 and report presence changes Giuliano Procida
2022-06-30 16:41         ` Dodji Seketeli [this message]
2022-06-13 14:25       ` [PATCH v5 4/4] add Linux kernel symbol namespace support Giuliano Procida
2022-07-01 12:54         ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu82cden.fsf@seketeli.org \
    --to=dodji@seketeli.org \
    --cc=gprocida@google.com \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    --cc=maennich@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).