From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by sourceware.org (Postfix) with ESMTPS id C1DE0385740F for ; Thu, 10 Jun 2021 13:31:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1DE0385740F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id D9B4D6000E; Thu, 10 Jun 2021 13:31:38 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 1FBE95800FF; Thu, 10 Jun 2021 15:31:36 +0200 (CEST) From: Dodji Seketeli To: Ben Woodard via Libabigail Cc: Ben Woodard , bolo@cs.wisc.edu Subject: Re: [PATCH] Fix trivial typo when printing version string Organization: Me, myself and I References: <20210609215012.1875276-1-woodard@redhat.com> X-Operating-System: Fedora 35 X-URL: http://www.seketeli.net/~dodji Date: Thu, 10 Jun 2021 15:31:36 +0200 In-Reply-To: <20210609215012.1875276-1-woodard@redhat.com> (Ben Woodard via Libabigail's message of "Wed, 9 Jun 2021 14:50:12 -0700") Message-ID: <87tum526dj.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 13:31:42 -0000 Ben Woodard via Libabigail a =C3=A9crit: > When abicompat prints its version string, it does not terminate > it with a newline the way that other commands do. Contributed by > Bolo. > > Signed-off-by: Ben Woodard Thanks for this patch! I have just added a ChangeLog-compatible part to this commit log, as stated in the COMMIT-LOG-GUIDELINES file at https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dblob;f=3DCOMMIT-LOG-GUID= ELINES. Below is the patch that was applied. Thanks! >From 519d7ce8e5773099fbfa0515d00397c008a72327 Mon Sep 17 00:00:00 2001 From: Ben Woodard via Libabigail Date: Wed, 9 Jun 2021 14:50:12 -0700 Subject: [PATCH] Fix trivial typo when printing version string When abicompat prints its version string, it does not terminate it with a newline the way that other commands do. Contributed by Bolo. * tools/abicompat.cc (main): Add a newline after version string. Signed-off-by: Ben Woodard Signed-off-by: Dodji Seketeli --- tools/abicompat.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/abicompat.cc b/tools/abicompat.cc index f9b019fb..be3946e1 100644 --- a/tools/abicompat.cc +++ b/tools/abicompat.cc @@ -633,7 +633,8 @@ main(int argc, char* argv[]) if (opts.display_version) { emit_prefix(argv[0], cout) - << abigail::tools_utils::get_library_version_string(); + << abigail::tools_utils::get_library_version_string() + << "\n"; return 0; } =20 --=20 2.30.0 Cheers, --=20 Dodji