From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by sourceware.org (Postfix) with ESMTPS id 732003851C1F for ; Tue, 16 Mar 2021 10:38:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 732003851C1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodji@seketeli.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 3636DC0005; Tue, 16 Mar 2021 10:38:52 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 85CF658000E; Tue, 16 Mar 2021 11:38:52 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 11/20] Switch kernel stuff over to new symtab and drop unused code Organization: Me, myself and I References: <20200619214305.562-1-maennich@google.com> <20210127125853.886677-1-maennich@google.com> <20210127125853.886677-12-maennich@google.com> X-Operating-System: Fedora 34 X-URL: http://www.seketeli.net/~dodji Date: Tue, 16 Mar 2021 11:38:52 +0100 In-Reply-To: <20210127125853.886677-12-maennich@google.com> (Matthias Maennich's message of "Wed, 27 Jan 2021 12:58:44 +0000") Message-ID: <87tupbxu0z.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 10:38:57 -0000 Matthias Maennich a =C3=A9crit: > Now that the new symtab implementation is capable of reading the > ksymtab, we can switch over the implementation to gather information > from there and delete all now-obsolete code. > > * src/abg-dwarf-reader.cc (read_context::ksymtab_format_): Delete. > (read_context::ksymtab_entry_size_): Likewise. > (read_context::nb_ksymtab_entries_): Likewise. > (read_context::nb_ksymtab_gpl_entries_): Likewise. > (read_context::ksymtab_section_): Likewise. > (read_context::ksymtab_reloc_section_): Likewise. > (read_context::ksymtab_gpl_section_): Likewise. > (read_context::ksymtab_gpl_reloc_section_): Likewise. > (read_context::ksymtab_strings_section_): Likewise. > (read_context::linux_exported_fn_syms): Likewise. > (read_context::linux_exported_var_syms): Likewise. > (read_context::linux_exported_gpl_fn_syms): Likewise. > (read_context::linux_exported_gpl_var_syms): Likewise. > (read_context::initialize): Remove initializations accordingly. > (read_context::find_ksymtab_section): Delete. > (read_context::find_ksymtab_gpl_section): Likewise. > (read_context::find_ksymtab_reloc_section): Likewise. > (read_context::find_ksymtab_gpl_reloc_section): Likewise. > (read_context::find_ksymtab_strings_section): Likewise. > (read_context::find_any_ksymtab_section): Likewise. > (read_context::find_any_ksymtab_reloc_section): Likewise. > (read_context::lookup_elf_symbol_from_index): Adjust. > (read_context::linux_exported_fn_syms): Delete. > (read_context::create_or_get_linux_exported_fn_syms): Likewise. > (read_context::linux_exported_var_syms): Likewise. > (read_context::create_or_get_linux_exported_var_syms): Likewise. > (read_context::linux_exported_gpl_fn_syms): Delete. > (read_context::create_or_get_linux_exported_gpl_fn_syms): Likewise. > (read_context::linux_exported_gpl_var_syms): Likewise. > (read_context::create_or_get_linux_exported_gpl_var_syms): Likewise. > (read_context::try_reading_first_ksymtab_entry): Likewise. > (read_context::try_reading_first_ksymtab_entry_using_pre_v4_19_format): = Likewise. > (read_context::try_reading_first_ksymtab_entry_using_v4_19_format): Like= wise. > (read_context::get_ksymtab_format_module): Likewise. > (read_context::get_ksymtab_format): Likewise. > (read_context::get_ksymtab_symbol_value_size): Likewise. > (read_context::get_ksymtab_entry_size): Likewise. > (read_context::get_nb_ksymtab_entries): Likewise. > (read_context::get_nb_ksymtab_gpl_entries): Likewise. > (read_context::populate_symbol_map_from_ksymtab): Likewise. > (read_context::populate_symbol_map_from_ksymtab_reloc): Likewise. > (read_context::load_kernel_symbol_table): Likewise. > (read_context::load_ksymtab_symbols): Likewise. > (read_context::load_ksymtab_gpl_symbols): Likewise. > (read_context::load_linux_specific_exported_symbol_maps): Likewise. > (read_context::load_symbol_maps): Do not load kernel symbol maps. > (read_context::maybe_adjust_sym_address_from_v4_19_ksymtab): Delete. > (read_context::add_fn_symbols_to_map): Likewise. > (read_context::add_var_symbols_to_map): Likewise. > (read_context::read_debug_info_into_corpus): Fill export maps > from new symtab. > (read_context::lookup_elf_fn_symbol_from_address): Delete. > (read_context::lookup_elf_var_symbol_from_address): Likewise. > (read_context::lookup_elf_symbol_from_address): Likewise. > (read_context::lookup_public_function_symbol_from_elf): Likewise. > (read_context::fun_entry_addr_sym_map_sptr): Likewise. > (read_context::fun_entry_addr_sym_map): Likewise. > (read_context::var_addr_sym_map): Likewise. > > Reviewed-by: Giuliano Procida > Signed-off-by: Matthias Maennich OK to apply to master once the prerequisite patches are in. Thanks! Cheers, --=20 Dodji