* [PATCH] make: add distcheck-fast target
@ 2020-04-20 7:46 Matthias Maennich
2020-04-20 12:38 ` Dodji Seketeli
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Maennich @ 2020-04-20 7:46 UTC (permalink / raw)
To: libabigail; +Cc: dodji, gprocida, kernel-team, maennich
The default compression flag defined by automake via GZIP_ENV is --best.
That is pretty expensive for when you just want to make sure your change
is done properly to pass 'make distcheck'.
Hence add a convenience target 'make distcheck-fast' that sets GZIP_ENV
to --fast and runs distcheck with that.
On my machine, this almost cuts the 'make distcheck' time in half:
distcheck 4min 40s
distcheck-fast 2min 32s
This is not invasive as it does not change the existing distcheck
target.
* Makefile.am: add distcheck-fast make target
Signed-off-by: Matthias Maennich <maennich@google.com>
---
Makefile.am | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 396d64238840..f4dbff250059 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -82,3 +82,9 @@ tarball-and-all: tag-and-all
tag-and-all: distcheck
$(MAKE) tag-release-only
+
+# the default for GZIP_ENV is --best, which is pretty slow for check runs
+# distcheck-fast therefore compresses with --fast instead
+distcheck-fast:
+ $(MAKE) distcheck GZIP_ENV="--fast"
+
--
2.26.1.301.g55bc3eb7cb9-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] make: add distcheck-fast target
2020-04-20 7:46 [PATCH] make: add distcheck-fast target Matthias Maennich
@ 2020-04-20 12:38 ` Dodji Seketeli
2020-04-22 11:19 ` Mark Wielaard
0 siblings, 1 reply; 3+ messages in thread
From: Dodji Seketeli @ 2020-04-20 12:38 UTC (permalink / raw)
To: Matthias Maennich; +Cc: libabigail, gprocida, kernel-team
Matthias Maennich <maennich@google.com> a écrit:
> The default compression flag defined by automake via GZIP_ENV is --best.
> That is pretty expensive for when you just want to make sure your change
> is done properly to pass 'make distcheck'.
>
> Hence add a convenience target 'make distcheck-fast' that sets GZIP_ENV
> to --fast and runs distcheck with that.
>
> On my machine, this almost cuts the 'make distcheck' time in half:
>
> distcheck 4min 40s
> distcheck-fast 2min 32s
>
> This is not invasive as it does not change the existing distcheck
> target.
>
> * Makefile.am: add distcheck-fast make target
Applied to master. Thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] make: add distcheck-fast target
2020-04-20 12:38 ` Dodji Seketeli
@ 2020-04-22 11:19 ` Mark Wielaard
0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2020-04-22 11:19 UTC (permalink / raw)
To: Dodji Seketeli, Matthias Maennich; +Cc: kernel-team, libabigail, gprocida
On Mon, 2020-04-20 at 14:38 +0200, Dodji Seketeli wrote:
> Matthias Maennich <maennich@google.com> a écrit:
>
> > The default compression flag defined by automake via GZIP_ENV is --best.
> > That is pretty expensive for when you just want to make sure your change
> > is done properly to pass 'make distcheck'.
> >
> > Hence add a convenience target 'make distcheck-fast' that sets GZIP_ENV
> > to --fast and runs distcheck with that.
> >
> > On my machine, this almost cuts the 'make distcheck' time in half:
> >
> > distcheck 4min 40s
> > distcheck-fast 2min 32s
> >
> > This is not invasive as it does not change the existing distcheck
> > target.
> >
> > * Makefile.am: add distcheck-fast make target
>
> Applied to master. Thanks!
It also saves minutes on my machine. So I am using make distcheck-fast
on the buildbot workers too now. Hopefully that will speed up things
there too.
Thanks,
Mark
P.S. The ppc64 and ppc64le workers are down at the moment. They should
hopefully get back online soon (and go through the backlog).
https://builder.wildebeest.org/buildbot/#/pendingbuildrequests
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-22 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 7:46 [PATCH] make: add distcheck-fast target Matthias Maennich
2020-04-20 12:38 ` Dodji Seketeli
2020-04-22 11:19 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).