From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 568433AA8C0A for ; Thu, 17 Nov 2022 15:36:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 568433AA8C0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668699363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qr9Yst8kbbOVOPW4k2HhOQJOZ+nWgKPhugCGCSFBvds=; b=NEKLY3dg4CPqSSVajaAY6bsVWd1TCNbekXl6hGyiNwROPv8+vIuEp6L3W9/Ppp9HQRXLXG Rlm60EGugBaRF61FD8LyoEb8v2fOxpWHV3bQa+Ba0I3Px8hHcYHGd5rcGWJcW9B6fM3nby bIvwedp6qYnfrAYoelD+FSrM/Xe4CcI= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-584-Nmzi8nmtO2yLIE99y3hEwg-1; Thu, 17 Nov 2022 10:35:54 -0500 X-MC-Unique: Nmzi8nmtO2yLIE99y3hEwg-1 Received: by mail-qk1-f199.google.com with SMTP id q14-20020a05620a0d8e00b006ef0350dae1so2488828qkl.12 for ; Thu, 17 Nov 2022 07:35:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qr9Yst8kbbOVOPW4k2HhOQJOZ+nWgKPhugCGCSFBvds=; b=kBB3FaDLojtmEH5S1NP44+fvhB+SKU81v8/bm77vMqP7rLNIEJL23ZaSEvKIzzgjgF td//qrvyUiYJQ0U9T7ThHpZUXTRDwUCoKkBR+Nd7ssc/n5WvBJeZm4UAF97XjxDWXxUF tDbUiGIKaaCfLadQ6fv7HBN6bhx22OCXhcHCSyQ5exizc1pE6tJTrm2y8gtQHzG3gUTm 9PxzDfqoKyaySfLVtqYl6WLW3NVoRgTYR/tSiFL9XeNsJH68naELcfHl85AdWg9mnNvY TftIiNTIACfr5OyaqNwyFGK4jXZ/NwugOfS1rIvuc3udm/HWdB9fa/wWCmsQZDGfyFKF nwYQ== X-Gm-Message-State: ANoB5pmB1c1bBBl6P1rb644Io3mWRMToouS5jeA2tlC6sQVaSkvhev/Y x2gopXMI9rXsWwTv73YOQpTpVUY4Z2GLYnU7L3YgGLIxxQDKORiMcCrrWkzuuYfIp2omtypgk1e NHYj6MkqcHCnUOqK9p6Tu X-Received: by 2002:a37:407:0:b0:6fa:2f1d:303 with SMTP id 7-20020a370407000000b006fa2f1d0303mr2013660qke.770.1668699353874; Thu, 17 Nov 2022 07:35:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf7YkmOdks1LAAvo4c1Z2fv7KV9xLBlLWttonCLkHAQ90CTYDCMqYKx3Xcw2LAvCF3k0bqmgjg== X-Received: by 2002:a37:407:0:b0:6fa:2f1d:303 with SMTP id 7-20020a370407000000b006fa2f1d0303mr2013643qke.770.1668699353648; Thu, 17 Nov 2022 07:35:53 -0800 (PST) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id bk1-20020a05620a1a0100b006ee77f1ecc3sm652736qkb.31.2022.11.17.07.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 07:35:53 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id 3B238581C59; Thu, 17 Nov 2022 16:35:49 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: Dodji Seketeli , woodard@redhat.com, guillermo.e.martinez@oracle.com, jose.marchesi@oracle.com, libabigail@sourceware.org Subject: Re: [PATCH 1/2] Use environment by reference Organization: Red Hat / France References: <87k03uom03.fsf@redhat.com> <87cz9molk8.fsf@redhat.com> X-Operating-System: Fedora 38 X-URL: http://www.redhat.com Date: Thu, 17 Nov 2022 16:35:49 +0100 In-Reply-To: (Giuliano Procida's message of "Thu, 17 Nov 2022 14:17:42 +0000") Message-ID: <87v8ndmw4q.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Giuliano Procida writes: [...] >> @@ -1358,7 +1358,7 @@ lookup_symbol_from_elf_hash_tab(const environment* env, >> /// >> /// @return true iff the symbol was found. >> static bool > > You're losing the const in the next few functions. There may be some > other similar cases. Oh, good catch. I have fixed those occurences, thanks! > Otherwise, this looks like good to me. Thanks, I have updated the branch for now. Cheers, [...] -- Dodji