From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 820013858D1E for ; Tue, 8 Feb 2022 10:28:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 820013858D1E Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-GtgSTSBeNHiH1RfYyLOb7w-1; Tue, 08 Feb 2022 05:28:03 -0500 X-MC-Unique: GtgSTSBeNHiH1RfYyLOb7w-1 Received: by mail-qv1-f71.google.com with SMTP id t5-20020a056214118500b0042c272ede45so77472qvv.13 for ; Tue, 08 Feb 2022 02:28:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=GBFFblkkLwKEgwDbJPwzixK+9Qtb5uy3vIfmAXw5CdU=; b=oV6+NOD8nMHl5ydjoOLyOY15UrMx/n3clkPpQVCJiO+GsbSWIMzuBMpz48Vp05L/9G ky6EPbF0hTJoE3hHGhIlhkoYdEyafEvQuWFU1oMe4pRGz2Q1zmYbZVoTSCqnAI/ZKTsS /CgEGul0MuEsOnQA2+ZyVWT8Tx4BctSKl6eUl+GMWB0B9opb3alWe6nYWWrEeQ2M1Dmb nsNyePuyYKct7GpBZBPWQTeakN3YDvKza8alScrz99B/ICdUElsU2X6ixBwLsbx6KrKD o5z5T4XWmJmmwQa4CqUbszOuwlEbBW6peaNj8jiTdNq++b/n4dK8pu/0rZcxeWLUSB3u SOkA== X-Gm-Message-State: AOAM531I1zm+Ggl3sIq7jqR/5LRWGgUkZoe6U1wS4NnIaL1/mW79X6dY cqF40gun9AQu460DyioDFJLc3T2krjYdMcXgpA/7IRmo9nS2o2tK4tRctKxhVjbrpdnM7U9Wzf0 0FeEOsgajDbUb78MSWbzR X-Received: by 2002:a05:622a:1102:: with SMTP id e2mr2393324qty.439.1644316082628; Tue, 08 Feb 2022 02:28:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWdwoeYy4zRWPbpMK9ZcW+eFjELwbW0YkLo6wfQcdPEQnnbE8z1NeyRMZF4nKo3Ihd2T5PqA== X-Received: by 2002:a05:622a:1102:: with SMTP id e2mr2393316qty.439.1644316082415; Tue, 08 Feb 2022 02:28:02 -0800 (PST) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id f14sm6890607qko.117.2022.02.08.02.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 02:28:01 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id 36FFE581C3A; Tue, 8 Feb 2022 11:27:59 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org Subject: Re: [PATCH 2/2] Bug 26646 - unexpected declaration-only types Organization: Red Hat / France References: <87v8xrlyyd.fsf@redhat.com> <87mtj3lyn8.fsf@seketeli.org> X-Operating-System: Fedora 36 X-URL: http://www.redhat.com Date: Tue, 08 Feb 2022 11:27:58 +0100 In-Reply-To: (Giuliano Procida's message of "Mon, 7 Feb 2022 16:26:34 +0000") Message-ID: <87v8xplkk1.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 10:28:06 -0000 Giuliano Procida writes: > This looks good to me. Thanks! > > In the case of the two kernel ABIs, it eliminates one of the two > differences in declaration-only status. I'll follow up on the other > difference in the bug when I have a bit more information to share. Good to know, thank you. [...] >> >> * src/abg-dwarf-reader.cc (add_or_update_class_type): Do not reuse >> the IR for a DIE with the same textual representation as the one >> we are seeing now. >> * tests/data/test-annotate/test21-pr19092.so.abi: Adjust. >> * tests/data/test-read-dwarf/test21-pr19092.so.abi: Likewise. >> >> Signed-off-by: Dodji Seketeli > > Reviewed-by: Giuliano Procida Applied to master, thanks! [...] > > Cheers! > Cheers! -- Dodji