From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by sourceware.org (Postfix) with ESMTPS id BFBF93858408 for ; Mon, 20 Dec 2021 14:58:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFBF93858408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 0812F240007; Mon, 20 Dec 2021 14:58:43 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 190DB581C2E; Mon, 20 Dec 2021 15:58:42 +0100 (CET) From: Dodji Seketeli To: Thomas Schwinge Cc: libabigail@sourceware.org Subject: Re: [PATCH] abipkgdiff: Respect 'create_abi_file_path' interface Organization: Me, myself and I References: <20211210104150.3248635-1-thomas@codesourcery.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Mon, 20 Dec 2021 15:58:42 +0100 In-Reply-To: <20211210104150.3248635-1-thomas@codesourcery.com> (Thomas Schwinge's message of "Fri, 10 Dec 2021 11:41:50 +0100") Message-ID: <87v8zj8grh.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 14:58:47 -0000 Hello, Thomas Schwinge a =C3=A9crit: > Currently we may run into this: > > [...] > abipkgdiff: Could not create the directory tree to store the abi for = '[...]' > abipkgdiff: Writting ABIXML file '' ... > abipkgdiff: Wrote ABIXML file '' OK > abipkgdiff: Reading ABIXML file '' ... > abipkgdiff: Could not read temporary ABIXML file '' > =3D=3D=3D=3D Error happened during self check of '[...]' =3D=3D=3D=3D > [...] > > That is, after a failed 'create_abi_file_path', we proceed with an empty > 'abi_file_path' -- because that one only gets set "iff the function return > true". So we ought to 'return abigail::tools_utils::ABIDIFF_ERROR' in th= at > case. > > (It's likewise strange why 'create_write_context'/'write_corpus' succeed = with > an empty 'abi_file_path', but that's for another day...) > > * tools/abipkgdiff.cc (compare_to_self): Respect > 'create_abi_file_path' interface. > > Signed-off-by: Thomas Schwinge Applied to master, thanks! [...] Cheers, --=20 Dodji