From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by sourceware.org (Postfix) with ESMTPS id 38DAD3857421 for ; Fri, 16 Jul 2021 15:18:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38DAD3857421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5E3C5E0013; Fri, 16 Jul 2021 15:18:37 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 25FC0580100; Fri, 16 Jul 2021 17:18:35 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH, applied] elf_symbol: remove "is Linux string constant" property Organization: Me, myself and I References: <20210706163602.307939-1-gprocida@google.com> X-Operating-System: Fedora 35 X-URL: http://www.seketeli.net/~dodji Date: Fri, 16 Jul 2021 17:18:34 +0200 In-Reply-To: <20210706163602.307939-1-gprocida@google.com> (Giuliano Procida's message of "Tue, 6 Jul 2021 17:36:02 +0100") Message-ID: <87v95ae185.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2021 15:18:43 -0000 Giuliano Procida a =C3=A9crit: > This boolean property was obsoleted by the new symtab reader > implementation. It has no users. > > Following this change, the find_ksymtab_strings_section function joins > find_ksymtab_section and find_ksymtab_gpl_section in having no users. [...] Matthias Maennich a =C3=A9crit: > Thanks for clearing up this leftover TODO! Indeed, thanks a lot for looking into this! > > * include/abg-ir.h (elf_symbol::elf_symbol): Drop > is_linux_string_cst argument. > (elf_symbol::create): Likewise. > (elf_symbol::get_is_linux_string_cst): Drop method. > * src/abg-dwarf-reader.cc (lookup_symbol_from_sysv_hash_tab): > Remove code that gets the index of the __ksymtab_strings > section. Drop corresponding elf_symbol::create argument. > (lookup_symbol_from_gnu_hash_tab): Likewise. > (lookup_symbol_from_symtab): Likewise. > (create_default_fn_sym): Drop false is_linux_string_cst > argument to elf_symbol::create. > * src/abg-ir.cc (elf_symbol::priv): Drop is_linux_string_cst_ > member variable. > (elf_symbol::priv default ctor): Drop initialisation of > is_linux_string_cst_. > (elf_symbol::priv normal ctor): Drop is_linux_string_cst > argument and corresponding is_linux_string_cst_ > initialisation. > (elf_symbol::elf_symbol ctor): Drop is_linux_string_cst > argument and corresponding forwarding to priv ctor. > (elf_symbol::create): Drop is_linux_string_cst argument and > corresponding forwarding to ctor. > (elf_symbol::get_is_linux_string_cst): Drop method. > * src/abg-reader.cc (build_elf_symbol): Drop false > is_linux_string_cst argument to elf_symbol::create. > * src/abg-symtab-reader.cc (symtab::load): Likewise. > > Signed-off-by: Giuliano Procida > Reviewed-by: Matthias Maennich Applied to master. Thanks! [...] Cheers, --=20 Dodji