From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id B77693858026 for ; Fri, 27 Nov 2020 17:08:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B77693858026 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-cVML1ZEdO6WYJhtm79SwxQ-1; Fri, 27 Nov 2020 12:08:05 -0500 X-MC-Unique: cVML1ZEdO6WYJhtm79SwxQ-1 Received: by mail-wr1-f69.google.com with SMTP id b5so3701453wrp.3 for ; Fri, 27 Nov 2020 09:08:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Op/SEwVP21mhrI3UZk8b6eLyzqyMIZKdTrlylfzCXyA=; b=RgLlyswArpAqr3A8Xn6iYd6ca1IP3M0lHFqUptLfAW1R9vf0MZP/v8AlwHp5pMn8oR hFimqcteVk8e4YbtISWX6a0ZFkID5yjWZUNkM9xLUieETywPtqRsbjgVjLN+iqJP69cv SGUUOBMvwENGu2eZ2rRHlKaYt/Xv/DCkqcmHZdzWCE+ofhwxtjhWUvqdju5T1r0gip3Z UhYnq7Y83jh4A1RnMf9XT+4TKB/v5qNL6Mpr8sFisYjphT5f8PxJZi+xU4i34KacOpAT zuDn4kbZcFMATo/gqahBBbo8v+B0QvMYHM1ags9IiNrev82HzEmeuhwWTleJwR/+6/sd 6HNw== X-Gm-Message-State: AOAM532AE/9oLpzytuhgYwaYRimmLDlOy7/z4EbLSCbdhebcrT9OnL1t jnn5y5MOWWSEvlepZQUjliRP4J6tCaKW/e1ZrGFh6KR5ZNX4AhVghe/TS3CVFuE+48dMfZtw+BM +bmA8Czo9MShafleNhlnG X-Received: by 2002:adf:bb05:: with SMTP id r5mr11907476wrg.295.1606496883864; Fri, 27 Nov 2020 09:08:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4THjysMMP3wIHHr6qSDeCe4HeHiQXmsQjIyb2yZqLSPfMT6BU6Af+gtvvJiSN8wnG5A32/g== X-Received: by 2002:adf:bb05:: with SMTP id r5mr11907448wrg.295.1606496883601; Fri, 27 Nov 2020 09:08:03 -0800 (PST) Received: from localhost (91-166-131-65.subs.proxad.net. [91.166.131.65]) by smtp.gmail.com with ESMTPSA id h15sm15412276wrw.15.2020.11.27.09.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 09:08:03 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id B538A5802B4; Fri, 27 Nov 2020 18:08:01 +0100 (CET) From: Dodji Seketeli To: Dodji Seketeli Cc: libabigail@sourceware.org, woodard@redhat.com Subject: [PATCH 5/6] abidw: make --abidiff report any change against own ABIXML Organization: Red Hat / France References: <87h7pa7n8c.fsf@redhat.com> X-Operating-System: Fedora 34 X-URL: http://www.redhat.com Date: Fri, 27 Nov 2020 18:08:01 +0100 In-Reply-To: <87h7pa7n8c.fsf@redhat.com> (Dodji Seketeli's message of "Fri, 27 Nov 2020 17:56:03 +0100") Message-ID: <87v9dq683y.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 17:08:08 -0000 Hello, Sometimes, "abidw --abidiff " would pass while "abidw > abi; abidiff abi" would fail. This is because "abidw --abidiff" emits an error only when the comparison between the binary and its ABIXML representation yields and incompatible change. Now that many subtle causes of spurious ABI change report emitted when comparing a binary against its own ABIXML have been fixed, this patch makes it so that *any* change would make abidw --abidiff to emit an error. * tools/abidw.cc (load_corpus_and_write_abixml): Emit an error when comparing the binary to its ABIXML representation yields any change. Signed-off-by: Dodji Seketeli Applied to master. --- tools/abidw.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/abidw.cc b/tools/abidw.cc index 756a29ec..6e37132c 100644 --- a/tools/abidw.cc +++ b/tools/abidw.cc @@ -593,7 +593,7 @@ load_corpus_and_write_abixml(char* argv[], emit_prefix(argv[0], cerr) << "computed diff in: " << t << "\n"; - bool has_error = diff->has_incompatible_changes(); + bool has_error = diff->has_changes(); if (has_error) { t.start(); -- 2.29.2 -- Dodji