From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by sourceware.org (Postfix) with ESMTPS id D8B233985421 for ; Thu, 1 Oct 2020 14:43:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D8B233985421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 0020B20000C; Thu, 1 Oct 2020 14:42:59 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 9ABF51800938; Thu, 1 Oct 2020 16:42:58 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 2/7] Fix two wrongs in test suppression regex Organization: Me, myself and I References: <20200817093819.172380-1-gprocida@google.com> <20200817093819.172380-3-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.seketeli.net/~dodji Date: Thu, 01 Oct 2020 16:42:58 +0200 In-Reply-To: <20200817093819.172380-3-gprocida@google.com> (Giuliano Procida's message of "Mon, 17 Aug 2020 10:38:14 +0100") Message-ID: <87v9fuovm5.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 14:43:04 -0000 Giuliano Procida a =C3=A9crit: > The suppression specification in test38-char-class-in-ini.abignore was > introduced in commit 1478d9cc1c74ca3a2be89cd09aac5afcbdf818c7. > > Unfortunately it contains two errors. One causes the file name not to > match as the string is the full path, not the base name. The other is > a typo that causes the file name match not to even be attempted. The > two mistakes cancel in the test, but result in a suppression > specification that is broader than intended. > > * tests/data/test-diff-suppr/test38-char-class-in-ini.abignore: > Don't anchor regex match to beginning of file name. > Change "filename_regexp" to "file_name_regexp". > > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji