Re: [PATCH v2 2/2] abidiff: Fix anonymous member size change reports.

[Dodji Seketeli <dodji@seketeli.org>]

Giuliano Procida <gprocida@google.com> a écrit:

[...]
>
> 	* src/abg-reporter-priv.cc (represent): In the var_diff_sptr
> 	overload, factor out some expressions as local variables, rely
> 	on diff_to_be_reported to decide whether to emit a change,
> 	fold together local/non-local change reporting using
> 	local_changes to preserve current name formatting differences,
> 	keep track explicitly of whether size information has been
> 	emitted and ensure it happens if needed, make offset and size
> 	change reporting for anonymous data members more meaningful.
> 	* tests/test-abidiff-exit.cc: Run new test cases.
> 	* tests/data/Makefile.am: Add new test files.
> 	* tests/data/test-abidiff-exit/test-member-size-v0.cc: New
> 	test.
> 	* tests/data/test-abidiff-exit/test-member-size-v0.o: Ditto.
> 	* tests/data/test-abidiff-exit/test-member-size-v1.cc: Ditto.
> 	* tests/data/test-abidiff-exit/test-member-size-v1.o: Ditto.
> 	* tests/data/test-abidiff-exit/test-member-size-report0.txt:
> 	New test, default mode.
> 	* tests/data/test-abidiff-exit/test-member-size-report1.txt:
> 	New test, --leaf-changes-only mode.
> 	* tests/data/test-abidiff-exit/test-leaf-cxx-members-report.txt:
> 	Eliminate duplicate reporting of member sizes.
> 	* tests/data/test-abidiff-exit/test-leaf-more-report.txt: Ditto.
> 	* tests/data/test-abidiff-exit/test-leaf-peeling-report.txt:
> 	Ditto.
> 	* tests/data/test-abidiff-exit/test-no-stray-comma-report.txt:
> 	Ditto.
> 	* tests/data/test-diff-dwarf/test45-anon-dm-change-report-0.txt:
> 	Add size report for anonymous data member.
> 	* tests/data/test-diff-filter/test44-anonymous-data-member-report-0.txt:
> 	Ditto.
> 	* tests/data/test-diff-pkg/libsigc++-2.0-0c2a_2.4.0-1_amd64--libsigc++-2.0-0v5_2.4.1-1ubuntu2_amd64-report-0.txt:
> 	Add missing size change report.
> 	* tests/data/test-diff-suppr/test36-leaf-report-0.txt: Remove
> 	size change report for previously reported type.
> 	* tests/data/test-diff-suppr/test46-PR25128-report-1.txt:
> 	Eliminate duplicate reporting of member size change.
> 	* tests/data/test-diff-suppr/test46-PR25128-report-2.txt:
> 	Ditto.

Applied to master, thanks!

Cheers,

-- 
		Dodji