From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by sourceware.org (Postfix) with ESMTPS id 7CB73385780C for ; Fri, 29 Apr 2022 10:57:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7CB73385780C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 5A983FF804; Fri, 29 Apr 2022 10:57:28 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 8CF995802BD; Fri, 29 Apr 2022 12:57:27 +0200 (CEST) From: Dodji Seketeli To: "Guillermo E. Martinez via Libabigail" Subject: Re: [PATCH v2] ctf-reader: Add support to undefined forward declaration types Organization: Me, myself and I References: <20211212041452.380448-1-guillermo.e.martinez@oracle.com> <20220318013036.2306102-1-guillermo.e.martinez@oracle.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Fri, 29 Apr 2022 12:57:27 +0200 In-Reply-To: <20220318013036.2306102-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Thu, 17 Mar 2022 19:30:36 -0600") Message-ID: <87wnf8f97s.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 10:57:32 -0000 Hello, "Guillermo E. Martinez via Libabigail" a =C3=A9crit: [...] > +static type_base_sptr > +process_ctf_forward_type(read_context *ctxt, > + corpus_sptr corp, > + translation_unit_sptr tunit, > + ctf_dict_t *ctf_dictionary, > + ctf_id_t ctf_type) This function lacks a doxgen comment. I have added it. Also, the 'corp' parameter is not used in the body of the function. So I have removed it. [...] > /// Build and return a struct type libabigail IR. > /// > /// @param ctxt the read context. > @@ -813,6 +860,12 @@ process_ctf_type(read_context *ctxt, > result =3D is_type(struct_decl); > break; > } > + case CTF_K_FORWARD: > + { > + result =3D process_ctf_forward_type(ctxt, corp, tunit, ctf_dicti= onary, > + ctf_type); I have updated this call to remove the "corp" parameter as it's not there anymore. > + } > + break; > case CTF_K_UNION: > { [...] > * src/abg-ctf-reader.cc (process_ctf_forward_type): New > function. > (process_ctf_type): New CTF_K_FORWARD case. > * tests/data/test-read-ctf/test-forward-undefine-type-decl.c: > New testcase. > * tests/data/test-read-ctf/test-forward-undefine-type-decl.abi: > New expected result. > * tests/data/test-read-ctf/test-forward-undefine-type-decl.o > New test input. > * tests/test-read-ctf.cc: Add new testcase to test harness. > * tests/data/Makefile.am: Add new test input files to test harness. > > Signed-off-by: Guillermo E. Martinez Applying this to master, thanks! Cheers, --=20 Dodji