From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by sourceware.org (Postfix) with ESMTPS id 22D5F3858018 for ; Wed, 10 Mar 2021 10:20:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 22D5F3858018 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodji@seketeli.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id A6C84E0003; Wed, 10 Mar 2021 10:19:59 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 01C4B58000E; Wed, 10 Mar 2021 11:19:58 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, mark@klomp.org Subject: Re: [PATCH] DWARF reader: Interpret ARM32 ELF addresses correctly Organization: Me, myself and I References: <20210309225754.2759649-1-gprocida@google.com> X-Operating-System: Fedora 34 X-URL: http://www.seketeli.net/~dodji Date: Wed, 10 Mar 2021 11:19:58 +0100 In-Reply-To: <20210309225754.2759649-1-gprocida@google.com> (Giuliano Procida's message of "Tue, 9 Mar 2021 22:57:54 +0000") Message-ID: <87wnufz4xd.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2021 10:20:04 -0000 Giuliano Procida a =C3=A9crit: > Bug 27552 - libabigail needs to interpret ARM32 symbol addresses specially > > The ARM32 ELF specification specifies that bit 0 of an ELF function > address is a flag specifying whether the instructions are Thumb or > ARM. So clear this bit before using the addresses for symbol mapping. > > * src/abg-dwarf-reader.cc > (read_context::load_symbol_maps_from_symtab_section): Clear > bit zero of ARM32 function addresses. > * src/abg-elf-helpers.cc (architecture_is_arm32): Add new > function. > * src/abg-elf-helpers.h (architecture_is_arm32): Likewise. > * tests/data/test-read-dwarf/test-libandroid.so.abi: Update. > > Signed-off-by: Giuliano Procida Applied to master. Thanks! [...] --=20 Dodji