From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by sourceware.org (Postfix) with ESMTPS id 846A83858C2C for ; Fri, 10 Mar 2023 07:49:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 846A83858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 849B11C0002; Fri, 10 Mar 2023 07:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1678434578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5WlyNg+oNw/JJ7159YJEm/LPLmxGgF1DUz4bZ+bqeL4=; b=AbsSchIKjZ3D0Ka/tmCfaVFVS1MdPvyt7HDL9en/yBvqA3c+H0rktCDBmw8xRwMZW9K1ik DVinJXrg7HMrLGoGDB5JQzLQiLbq4KqfwpadlBWSkVPjPNBUleLCG6FeqsdgDDfPcG+knX hnFSg1SZYznV39WVTzp3KvP7LIjyKAHQ2aRbzEwb0jByxIkErxNG9Q88AJ/oplhax92+7v ErQ4L8MtymCd+FdaLGNX4rR+0N1RyzKQkFdwPu8/60cCLVM4oGvgzc9x3zF31gwMqjM4Qw z1LIig4qRsOUac7PbwqfLrBMFd7D5ycsWaUqFRzzOnvWcOlws8SBlMMajO/SeQ== Received: by localhost (Postfix, from userid 1000) id 0AAD5581C79; Fri, 10 Mar 2023 08:49:32 +0100 (CET) From: Dodji Seketeli To: "Guillermo E. Martinez via Libabigail" Cc: "Guillermo E. Martinez" Subject: Re: [PATCH] tools-utils: Looks for vmlinux binary in RPM debug package Organization: Me, myself and I References: <20230306155038.3316079-1-guillermo.e.martinez@oracle.com> <875ybbpb0v.fsf@seketeli.org> X-Operating-System: Fedora 38 X-URL: http://www.seketeli.net/~dodji Date: Fri, 10 Mar 2023 08:49:32 +0100 In-Reply-To: <875ybbpb0v.fsf@seketeli.org> (Dodji Seketeli's message of "Wed, 08 Mar 2023 15:34:24 +0100") Message-ID: <87y1o5nj03.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, [...] > On Wed, Mar 08, 2023 at 03:34:24PM +0100, Dodji Seketeli wrote: >> So, below is the resulting patch. >>=20 >> Could you please test it in your environment and tell me if it works for >> you, the way you expect it? "Guillermo E. Martinez" a =C3=A9crit: > Working as intended. Dodji Seketeli a =C3=A9crit: [...] > So, below is the resulting patch. [...] > From dc375bd1b7f15f41665f002ec61f68ce1e7ff889 Mon Sep 17 00:00:00 2001 > From: "Guillermo E. Martinez" > Date: Mon, 6 Mar 2023 09:50:38 -0600 > Subject: [PATCH] tools-utils: Fix looking for vmlinux binary in debuginfo= package > > When abipkgdiff is invoked on a `kernel' package, > compare_prepared_linux_kernel_packages fails to look for the `vmlinux' > file from the debuginfo package, because of a thinko. > > Then, build_corpus_group_from_kernel_dist_under, also fails to find > `vmlinux' from the debuginfo package because of another thinko. > > This patch fixes the two thinkos. > > * src/abg-tools-utils.cc > (get_binary_paths_from_kernel_dist): Fix a thinko and really use > the kernel_modules_root variable. Look for modules under > kernel_modules_root and look for vmlinux (if necessary) under > debug_info_root. Add comments. > (compare_prepared_linux_kernel_packages): Fix another thinko. Now > we do have the path to vmlinux, from debuginfo packages before > getting into get_binary_paths_from_kernel_dist. > > Signed-off-by: Guillermo E. Martinez > Signed-off-by: Dodji Seketeli OK, I have just applied this patch to master. Thank you for time and effort. It's appreciated. [...] Cheers, --=20 Dodji